Skip to content

test: check error msg in test/parallel/test-writeint.js#10755

Closed
liirene1 wants to merge 1 commit intonodejs:masterfrom
liirene1:testwriteint
Closed

test: check error msg in test/parallel/test-writeint.js#10755
liirene1 wants to merge 1 commit intonodejs:masterfrom
liirene1:testwriteint

Conversation

@liirene1
Copy link
Contributor

@liirene1 liirene1 commented Jan 12, 2017

Check error message in test/parallel/test-writeint.js

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. dont-land-on-v7.x labels Jan 12, 2017
@mscdex mscdex added buffer Issues and PRs related to the buffer subsystem. and removed dont-land-on-v7.x labels Jan 12, 2017
@mscdex
Copy link
Contributor

mscdex commented Jan 12, 2017

The first line of the commit message is too long (>50 characters). I think just including the filename itself ('test-writeint.js') is good enough.

Trott
Trott approved these changes Jan 12, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM if CI is green

@bengl
Copy link
Member

bengl commented Jan 12, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/5819/

@mscdex
Copy link
Contributor

mscdex commented Jan 12, 2017

minor nit: the word 'in' was dropped in the commit message

@italoacasas
Copy link

italoacasas commented Jan 13, 2017

Landed 6782577

italoacasas pushed a commit that referenced this pull request Jan 13, 2017
@liirene1
test: check error msg test-writeint.js
6782577 
PR-URL: #10755
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 18, 2017
@liirene1
test: check error msg test-writeint.js
99d22df 
PR-URL: nodejs#10755
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 23, 2017
@liirene1
test: check error msg test-writeint.js
02fa0b3 
PR-URL: nodejs#10755
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 25, 2017
@liirene1
test: check error msg test-writeint.js
434fe0f 
PR-URL: nodejs#10755
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@italoacasas italoacasas mentioned this pull request Jan 25, 2017
Closed
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 27, 2017
@liirene1
test: check error msg test-writeint.js
8b02b4e 
PR-URL: nodejs#10755
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@italoacasas italoacasas mentioned this pull request Jan 29, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Mar 8, 2017
@liirene1 @MylesBorins
test: check error msg test-writeint.js
b4b1c2e 
PR-URL: #10755
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins
Copy link
Contributor

MylesBorins commented Mar 8, 2017

Not landed on v4.x as the test was failing

MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@liirene1 @MylesBorins
test: check error msg test-writeint.js
c086bdc 
PR-URL: #10755
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

+1 more reviewer

@Fishrock123 Fishrock123 Fishrock123 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

buffer Issues and PRs related to the buffer subsystem. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.