test: move resource intensive test to sequential#10744
Closed
Trott wants to merge 1 commit intonodejs:masterfrom
Closed
test: move resource intensive test to sequential#10744Trott wants to merge 1 commit intonodejs:masterfrom
Trott wants to merge 1 commit intonodejs:masterfrom
Conversation
test-fs-readfile-tostring-fail is resource-intensive and is flaky in CI. Move to sequential tests so it is not competing for resources with other tests. Fixes: nodejs#10742
nodejs-github-bot
added
test
Member
Author
|
Sample failure of existing test in CI: https://ci.nodejs.org/job/node-test-commit-osx/7145/nodes=osx1010/console not ok 405 parallel/test-fs-readfile-tostring-fail
---
duration_ms: 60.203
severity: fail
stack: |-
timeout |
Member
Author
|
CI stress test 32 simultaneous runs of existing parallel test failing: CI stress test same thing but in sequential succeeding: |
Member
Author
Member
Author
|
/cc @nodejs/testing @mscdex |
Contributor
|
LGTM |
mscdex
added
fs
jasnell
approved these changes
Jan 11, 2017
Member
|
LGTM |
cjihrig
approved these changes
Jan 11, 2017
gibfahn
approved these changes
Jan 11, 2017
Member
Author
|
Anyone on board with a "this is trivial and doesn't need to wait 48 hours" for this? |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jan 12, 2017
test-fs-readfile-tostring-fail is resource-intensive and is flaky in CI. Move to sequential tests so it is not competing for resources with other tests. PR-URL: nodejs#10744 Fixes: nodejs#10742 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Member
Author
|
Landed in d3eca02. |
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 18, 2017
test-fs-readfile-tostring-fail is resource-intensive and is flaky in CI. Move to sequential tests so it is not competing for resources with other tests. PR-URL: nodejs#10744 Fixes: nodejs#10742 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 23, 2017
test-fs-readfile-tostring-fail is resource-intensive and is flaky in CI. Move to sequential tests so it is not competing for resources with other tests. PR-URL: nodejs#10744 Fixes: nodejs#10742 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 25, 2017
test-fs-readfile-tostring-fail is resource-intensive and is flaky in CI. Move to sequential tests so it is not competing for resources with other tests. PR-URL: nodejs#10744 Fixes: nodejs#10742 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 27, 2017
test-fs-readfile-tostring-fail is resource-intensive and is flaky in CI. Move to sequential tests so it is not competing for resources with other tests. PR-URL: nodejs#10744 Fixes: nodejs#10742 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 8, 2017
test-fs-readfile-tostring-fail is resource-intensive and is flaky in CI. Move to sequential tests so it is not competing for resources with other tests. PR-URL: #10744 Fixes: #10742 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
test-fs-readfile-tostring-fail is resource-intensive and is flaky in CI. Move to sequential tests so it is not competing for resources with other tests. PR-URL: #10744 Fixes: #10742 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test-fs-readfile-tostring-fail is resource-intensive and is flaky in
CI. Move to sequential tests so it is not competing for resources with
other tests.
Fixes: #10742
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test fs