test: improve test-stream2-large-read-stall#10725
Closed
stefanjudis wants to merge 1 commit intonodejs:masterfrom
stefanjudis:feature/change-var-to-const
Closed
test: improve test-stream2-large-read-stall#10725stefanjudis wants to merge 1 commit intonodejs:masterfrom stefanjudis:feature/change-var-to-const
stefanjudis wants to merge 1 commit intonodejs:masterfrom
stefanjudis:feature/change-var-to-const
Conversation
nodejs-github-bot
added
test
jasnell
approved these changes
Jan 10, 2017
mscdex
added
stream
italoacasas
approved these changes
Jan 10, 2017
Contributor
Author
|
Hmm... Can I help with the failing build somehow?
|
Member
|
@stefanjudis Looks like the problem is the all-important CERTIFY_SAFE checkbox was not checked when the CI job was kicked off. So, yeah, nothing to worry about. Let's just try again. CI again: https://ci.nodejs.org/job/node-test-pull-request/5797/ |
Member
|
Nope, that was just a oopsie on my part. I forgot to check a checkbox... thanks for restarting @Trott |
Contributor
Author
|
Cool. Thx. 🎉 Can you point me to some info on node's CI infrastructure? I've got no clue what checkbox you're talking about. :) |
Member
You won't be able to see the checkbox without a login on the CI infrastructure, but if you are intensely curious, you can read the docs near the end of the Reviewing PRs section of the onboarding doc. |
|
ping @stefanjudis can you rebase please |
* use const instead of var * use assert.strictEqual instead of assert.equal * use common.mustCall instead of process.on( 'exit', fn )
Contributor
Author
|
@italoacasas done. |
|
Landed c685638 thanks @stefanjudis |
italoacasas
pushed a commit
that referenced
this pull request
Jan 16, 2017
* use const instead of var * use assert.strictEqual instead of assert.equal * use common.mustCall instead of process.on( 'exit', fn ) PR-URL: #10725 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Italo A. Casas <[email protected]>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 18, 2017
* use const instead of var * use assert.strictEqual instead of assert.equal * use common.mustCall instead of process.on( 'exit', fn ) PR-URL: nodejs#10725 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Italo A. Casas <[email protected]>
This was referenced Jan 19, 2017
targos
pushed a commit
that referenced
this pull request
Jan 28, 2017
* use const instead of var * use assert.strictEqual instead of assert.equal * use common.mustCall instead of process.on( 'exit', fn ) PR-URL: #10725 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Italo A. Casas <[email protected]>
Merged
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 30, 2017
* use const instead of var * use assert.strictEqual instead of assert.equal * use common.mustCall instead of process.on( 'exit', fn ) PR-URL: nodejs#10725 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Italo A. Casas <[email protected]>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 30, 2017
* use const instead of var * use assert.strictEqual instead of assert.equal * use common.mustCall instead of process.on( 'exit', fn ) PR-URL: nodejs#10725 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Italo A. Casas <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Mar 8, 2017
* use const instead of var * use assert.strictEqual instead of assert.equal * use common.mustCall instead of process.on( 'exit', fn ) PR-URL: #10725 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Italo A. Casas <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Mar 8, 2017
* use const instead of var * use assert.strictEqual instead of assert.equal * use common.mustCall instead of process.on( 'exit', fn ) PR-URL: #10725 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Italo A. Casas <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
* use const instead of var * use assert.strictEqual instead of assert.equal * use common.mustCall instead of process.on( 'exit', fn ) PR-URL: #10725 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Italo A. Casas <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
* use const instead of var * use assert.strictEqual instead of assert.equal * use common.mustCall instead of process.on( 'exit', fn ) PR-URL: #10725 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Italo A. Casas <[email protected]>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)