doc: mention cc-ing nodejs/url team for reviews#10652
doc: mention cc-ing nodejs/url team for reviews#10652addaleax wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
doc
addaleax
added
meta
doc/onboarding-extras.md
Outdated
There was a problem hiding this comment.
nit: None Pretty much none of the other entries in the file seem to have .js
addaleax
force-pushed
the
doc-cc-nodejs-url
branch
from
fb0247a to
7194942
Compare
doc/onboarding-extras.md
Outdated
There was a problem hiding this comment.
Should it be lib/url? internal seems to be implied everywhere else (e.g., lib/fs would presumably include lib/internal/fs.js).
There was a problem hiding this comment.
I think it's about difference in implementations. WHATWG vs original url.
There was a problem hiding this comment.
yep... lib/internal/url.js is the home of the new implementation. Intentionally put there to keep it distinct from the older lib/url.js
There was a problem hiding this comment.
That's going to be confusing/unclear if there's not a separate entry for lib/url in addition to the entry for lib/internal/url. Not opposed to this landing as is, but if there's different people to cc depending on which one you're working on, I'd prefer that there be entries for both.
There was a problem hiding this comment.
Maybe adding a note column and mention that lib/url doesn't apply to this would help?
There was a problem hiding this comment.
I don’t think there is anybody in particular to ping for lib/url, and I think leaving this as-is is going to be fine. If it turns out to be a horrible idea, we can add a note or find people to @mention for lib/url.
doc/onboarding-extras.md
Outdated
There was a problem hiding this comment.
There is src/node_url.cc too.
EDIT: should be src/node_url, there is also a .h.
|
ping @addaleax |
Add the nodejs/url github team to the table of people to /cc for reviews on the WHATWG URL code.
addaleax
force-pushed
the
doc-cc-nodejs-url
branch
from
7194942 to
09590d0
Compare
|
Sorry, missed @joyeecheung’s review. updated! |
|
@joyeecheung ... does this look good to you now? |
Add the nodejs/url github team to the table of people to /cc for reviews on the WHATWG URL code. PR-URL: #10652 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
|
Landed in fa38361 |
Add the nodejs/url github team to the table of people to /cc for reviews on the WHATWG URL code. PR-URL: nodejs#10652 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
Add the nodejs/url github team to the table of people to /cc for reviews on the WHATWG URL code. PR-URL: nodejs#10652 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
Add the nodejs/url github team to the table of people to /cc for reviews on the WHATWG URL code. PR-URL: nodejs#10652 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
Add the nodejs/url github team to the table of people to /cc for reviews on the WHATWG URL code. PR-URL: nodejs#10652 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
Add the nodejs/url github team to the table of people to /cc for reviews on the WHATWG URL code. PR-URL: #10652 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
Add the nodejs/url github team to the table of people to /cc for reviews on the WHATWG URL code. PR-URL: #10652 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
10 participants
Add the nodejs/url github team to the table of people to /cc for
reviews on the WHATWG URL code.
fyi @nodejs/url