doc: mention cc-ing nodejs/python team for reviews#10637
Closed
addaleax wants to merge 1 commit intonodejs:masterfrom
Closed
doc: mention cc-ing nodejs/python team for reviews#10637addaleax wants to merge 1 commit intonodejs:masterfrom
addaleax wants to merge 1 commit intonodejs:masterfrom
Conversation
Add the nodejs/python github team to the table of people to /cc for reviews on python code.
Fishrock123
approved these changes
Jan 5, 2017
jasnell
approved these changes
Jan 5, 2017
Contributor
|
Oopsie. I totally forgot. Thanks @addaleax :-) |
thefourtheye
approved these changes
Jan 5, 2017
lpinca
approved these changes
Jan 5, 2017
Member
|
This should not need to wait the full 48 hours to land |
gibfahn
approved these changes
Jan 5, 2017
Member
gibfahn
left a comment
gibfahn
left a comment
There was a problem hiding this comment.
LGTM, did not know this was a thing!
Member
Author
|
Alright, went ahead and landed this in 103f6d7 |
addaleax
added a commit
that referenced
this pull request
Jan 6, 2017
Add the nodejs/python github team to the table of people to /cc for reviews on python code. PR-URL: #10637 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 18, 2017
Add the nodejs/python github team to the table of people to /cc for reviews on python code. PR-URL: nodejs#10637 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 19, 2017
Add the nodejs/python github team to the table of people to /cc for reviews on python code. PR-URL: nodejs#10637 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 24, 2017
Add the nodejs/python github team to the table of people to /cc for reviews on python code. PR-URL: nodejs#10637 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 27, 2017
Add the nodejs/python github team to the table of people to /cc for reviews on python code. PR-URL: nodejs#10637 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the @nodejs/python github team to the table of people to /cc for reviews on python code.
I was talking about this a while ago with @thefourtheye, and we did create the team, but I think we have (I have? 😄) just forgotten to add the team to the table in
doc/onboarding-extras.md.