test: Revert add option to use node in path#10613
test: Revert add option to use node in path#10613thefourtheye wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
tools
evanlucas
left a comment
evanlucas
left a comment
There was a problem hiding this comment.
Typically, revert commits are like Revert "<commit message>". I think changelog-maker even expects them to be that way.
|
@evanlucas But that exceeds the 50 chars limit. Is that okay? |
Fishrock123
left a comment
Fishrock123
left a comment
There was a problem hiding this comment.
+1 to @evanlucas's comemnt, this should be made via git revert unless there is some other issue.
Please merge some form of this ASAP.
|
@thefourtheye I think so for reverts. I would wager it's happened before. |
|
@thefourtheye yes. It should just be with |
This reverts commit 4198253.
thefourtheye
force-pushed
the
revert-tools-test
branch
from
9cc20d1 to
a3c8fac
Compare
|
@evanlucas @Fishrock123 Thanks 👍 Updated the commit. |
|
Oy good catch. Missed that entirely on my initial review. LGTM |
evanlucas
left a comment
evanlucas
left a comment
There was a problem hiding this comment.
LGTM. Also, +1 to landing sooner than the 48 minimum
|
Landed in 26bf954 |
jbergstroem
left a comment
jbergstroem
left a comment
There was a problem hiding this comment.
Post-merge approval. Can confirm.
This reverts commit 4198253. PR-URL: nodejs#10613 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com>
9 participants
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
tools
Description
This reverts commit 4198253, landed in
#9674.
This fails at
File "tools/test.py", line 1429, in ProcessOptions
options.j = int(cores) if cores is not None else
multiprocessing.cpu_count()
with the error
NotImplementedError: cannot determine number of cpus
from
File "...multiprocessing/init.py", line 136, in cpu_count
raise NotImplementedError('cannot determine number of cpus')
on MacOS machines.