test: improve the code in test-util-debug.js#10583
Closed
edsadr wants to merge 1 commit intonodejs:masterfrom
Closed
test: improve the code in test-util-debug.js#10583edsadr wants to merge 1 commit intonodejs:masterfrom
edsadr wants to merge 1 commit intonodejs:masterfrom
Conversation
* use const and let instead of var * use assert.strictEqual instead of assert.equal * use arrow functions
evanlucas
approved these changes
Jan 3, 2017
|
the |
cjihrig
approved these changes
Jan 3, 2017
Member
Author
|
@italoacasas that |
Contributor
|
There is already #10531 |
Member
Author
|
@thefourtheye .. right... I am closing this one if favor of #10531 and suggesting there to implement arrow functions to match mine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test