test: s/assert.notEqual()/assert.notStrictEqual()/#10541
Merged
cjihrig merged 1 commit intonodejs:masterfrom Jan 6, 2017
Merged
test: s/assert.notEqual()/assert.notStrictEqual()/#10541cjihrig merged 1 commit intonodejs:masterfrom
cjihrig merged 1 commit intonodejs:masterfrom
Conversation
sam-github
approved these changes
Dec 30, 2016
gibfahn
approved these changes
Dec 30, 2016
Contributor
Author
jasnell
approved these changes
Dec 30, 2016
Trott
approved these changes
Dec 31, 2016
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
LGTM if CI is ✅ . Left some nits, but they can be ignored and someone can do them later if they feel strongly about it.
test/parallel/test-console.js
Outdated
Member
There was a problem hiding this comment.
For readability, might be good to change this to assert(strings.shift().includes('foo: [Object]'));
test/parallel/test-crypto-fips.js
Outdated
Member
There was a problem hiding this comment.
Might be good to use .includes() here and change assert.notStrictEqual() to assert().
Member
There was a problem hiding this comment.
Here and the next line too. I'll stop. You get the idea. :-D
Member
|
Nit: commit message should start with an imperative verb. Although I guess arguably the |
Contributor
Author
|
FWIW, I went with |
italoacasas
approved these changes
Jan 2, 2017
Contributor
Author
|
New CI with @Trott's suggestions: https://ci.nodejs.org/job/node-test-pull-request/5729/ |
PR-URL: nodejs#10541 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 18, 2017
PR-URL: nodejs#10541 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 19, 2017
PR-URL: nodejs#10541 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>
targos
pushed a commit
that referenced
this pull request
Jan 28, 2017
PR-URL: #10541 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>
Merged
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 30, 2017
PR-URL: nodejs#10541 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 30, 2017
PR-URL: nodejs#10541 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>
Member
|
This will need backport PRs to land on v4 and v6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test