Conversation
nodejs-github-bot
added
lib / src
lib/timers.js
Outdated
There was a problem hiding this comment.
The exception is no longer thrown now, is this wanted?
There was a problem hiding this comment.
Agreed, looks like @JacksonTian forgot to rethrow the ex
There was a problem hiding this comment.
Thank you very much. fixed it.
|
hmm... @Fishrock123 are you familiar with why |
|
I think this is a performance optimization of some sort. This should be profiled. (e.g. |
gibfahn
added
the
performance
|
I hold the change of |
Fishrock123
left a comment
Fishrock123
left a comment
There was a problem hiding this comment.
(Requesting the aforementioned profiling)
|
@Fishrock123 How to profiling it? Hope to get some suggestions. |
|
ping @Fishrock123 ... any updates on this one? |
|
@JacksonTian this needs a rebase. And can you please comment when you did? There is no notification otherwise and I see that you rebased the last time you were asked to. |
JacksonTian
force-pushed
the
threw
branch
3 times, most recently
from
7c4d19f to
802c7b8
Compare
|
rebased. |
|
I benchmarked this recently and could not find any difference performance wise. |
BridgeAR
dismissed
Fishrock123’s stale review
No reaction and the performance should not be affected
BridgeAR
removed
performance
|
Landed in d56a82dfc3569332b1ad5a3249b8ca3405c37163 |
|
The test actually fails and I just force pushed to remove the commit again. |
|
It doesn't look like there were any CI runs for this so good call backing it out. Bonus points for it being within the 10 minute window ;-) |
|
I knew why I said
I somewhat had a bad feeling about it but I forgot to run it right before I pushed. |
|
Oh. Let's run CI again? |
Use try/catch to instead of threw.
|
Sorry, My mistake. After rebased with master, the test message no more need update. Now I removed it. |
|
Landed in 67d792a |
Use try/catch to instead of threw. PR-URL: #10534 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Use try/catch to instead of threw. PR-URL: nodejs#10534 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Use try/catch to instead of threw. PR-URL: nodejs/node#10534 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Use try/catch to instead of threw. PR-URL: #10534 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Use try/catch to instead of threw. PR-URL: #10534 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Use try/catch to instead of threw. PR-URL: #10534 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
|
backported to v6.x Let me know if it should be backed out |
Use try/catch to instead of threw. PR-URL: #10534 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
11 participants
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
bootstrap_node, module, timers