meta: modify pull request template for prepending#10484
Closed
Trott wants to merge 1 commit intonodejs:masterfrom
Closed
meta: modify pull request template for prepending#10484Trott wants to merge 1 commit intonodejs:masterfrom
Trott wants to merge 1 commit intonodejs:masterfrom
Conversation
The GitHub interface for new pull requests has started prepending commit messages for single-commit pull requests. It had previously been appending them. Modify the GitHub template to accommodate the new behavior.
Trott
added
the
meta
jasnell
approved these changes
Dec 28, 2016
targos
approved these changes
Dec 28, 2016
gibfahn
approved these changes
Dec 28, 2016
addaleax
approved these changes
Dec 28, 2016
cjihrig
approved these changes
Dec 28, 2016
Contributor
|
is it safe to assume there is no way to specify where this data will end up? was much nicer at the end. |
princejwesley
approved these changes
Dec 28, 2016
Member
|
I think this one is trivial enough not to have to wait the full 48 hours to land |
ChALkeR
approved these changes
Dec 29, 2016
sam-github
approved these changes
Dec 29, 2016
MylesBorins
approved these changes
Dec 29, 2016
jasnell
pushed a commit
that referenced
this pull request
Dec 29, 2016
The GitHub interface for new pull requests has started prepending commit messages for single-commit pull requests. It had previously been appending them. Modify the GitHub template to accommodate the new behavior. PR-URL: #10484 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Member
|
Landed 8dcebe8 |
evanlucas
pushed a commit
that referenced
this pull request
Jan 3, 2017
The GitHub interface for new pull requests has started prepending commit messages for single-commit pull requests. It had previously been appending them. Modify the GitHub template to accommodate the new behavior. PR-URL: #10484 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
Jan 4, 2017
The GitHub interface for new pull requests has started prepending commit messages for single-commit pull requests. It had previously been appending them. Modify the GitHub template to accommodate the new behavior. PR-URL: #10484 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GitHub interface for new pull requests has started prepending
commit messages for single-commit pull requests. It had previously
been appending them. Modify the GitHub template to accommodate the new
behavior.
Checklist
Affected core subsystem(s)
meta