test: stream readable resumeScheduled state#10299
Closed
italoacasas wants to merge 1 commit intonodejs:masterfrom
italoacasas:test/stream-readable-resumeScheduled
Closed
test: stream readable resumeScheduled state#10299italoacasas wants to merge 1 commit intonodejs:masterfrom italoacasas:test/stream-readable-resumeScheduled
italoacasas wants to merge 1 commit intonodejs:masterfrom
italoacasas:test/stream-readable-resumeScheduled
Conversation
italoacasas
added
stream
addaleax
approved these changes
Dec 16, 2016
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
LGTM up to the linter errors CI is showing
mcollina
requested changes
Dec 16, 2016
Member
mcollina
left a comment
mcollina
left a comment
There was a problem hiding this comment.
Can you please add checks also for on('data') and pipe()? Both of those trigger a resume().
cjihrig
requested changes
Dec 16, 2016
Contributor
There was a problem hiding this comment.
Can you separate these using block scopes, as done in a lot of other tests. Then, you can reuse the same variable names.
Author
cjihrig
requested changes
Dec 17, 2016
Contributor
There was a problem hiding this comment.
I would drop the "First test," "Second test," etc. from the comments. They will likely become out of date as people change the file.
cjihrig
approved these changes
Dec 20, 2016
Author
|
Landed 6137983 |
cjihrig
pushed a commit
to cjihrig/node
that referenced
this pull request
Dec 20, 2016
PR-URL: nodejs#10299 Ref: nodejs#8683 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
Adding test for the
resumeScheduledstate in stream.ReadableRef: #8683
CI: https://ci.nodejs.org/job/node-test-pull-request/5446/console
cc: @mcollina