aix: fix os.release()

[jBarz]

Checklist

• make -j4 test (UNIX)

Affected core subsystem(s)

os.release() on aix

Description of change

On AIX info.release is only a part of OS release version.
We need to combine info.version and info.release

[richardlau]

Maybe use snprintf for consistency with the rest of this file?

[Trott]

Should we add a test for this? Currently in test/parallel/test-os.js, there's this:

const release = os.release();
console.log('release = ', release);
is.string(release);
assert.ok(release.length > 0);

Maybe add something like this right below it?

//TODO: Check format on more than just AIX
if (common.isAix)
  assert.ok(/^\d+\.\d+\.\d+$/.test(release)); // <-- substitute whatever regexp makes sense for AIX

[Trott]

The docs for os.release() say this:

On POSIX systems, the operating system release is determined by calling uname(3).

With this change, is that still accurate for AIX? (If so, then great. If not, then perhaps a doc update should be included.)

[gibfahn]

cc/ @nodejs/platform-aix

[richardlau]

The docs for os.release() say this:

On POSIX systems, the operating system release is determined by calling uname(3).

With this change, is that still accurate for AIX? (If so, then great. If not, then perhaps a doc update should be included.)

Yes, the change is still accurate -- The code is still calling uname but is now combining two fields instead of just returning one. On AIX it looks like uname splits the OS version over two struct utsname fields, e.g. AIX 7.1 returns 7 in the version field and 1 in the release field.

[mhdawson]

LGTM. Would be nice to fill in additional test for other platforms, but since this is broken on AIX, don't want to hold up landing this for that.

[mhdawson]

@Trott look ok to you now ?

[Trott]

@mhdawson Test looks good to me. (The C++ change seems good to me too but I'm a beginner-at-best C++ coder so that probably doesn't mean much.)

[jasnell]

CI: https://ci.nodejs.org/job/node-test-pull-request/5557/

[jasnell]

Landed in 1c3c75d