Skip to content

test: refactor test-fs-fsync#10176

Closed
radelmann wants to merge 1 commit intonodejs:masterfrom
radelmann:test-fs-fsync
Closed

test: refactor test-fs-fsync#10176
radelmann wants to merge 1 commit intonodejs:masterfrom
radelmann:test-fs-fsync

Conversation

@radelmann
Copy link
Contributor

@radelmann radelmann commented Dec 8, 2016 •
edited
Loading

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change
  • replace var with const.
  • remove successes variable.
  • use assert.ifError() for handling all errors.
  • wrap all callbacks with common.mustCall().

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 8, 2016
@mscdex mscdex added the fs Issues and PRs related to the fs subsystem / file system. label Dec 8, 2016
santigimeno
santigimeno approved these changes Dec 8, 2016
View reviewed changes
Copy link
Member

@santigimeno santigimeno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one question

test/parallel/test-fs-fsync.js Outdated
Copy link
Member

@santigimeno santigimeno Dec 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrapping these in common.mustCall() is really necessary?

Copy link
Contributor Author

@radelmann radelmann Dec 8, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@santigimeno Great question! I went back and forth with this before submitting. On one hand, I think having them makes the test a little more explicit and self documenting. On the other hand, they are not really needed since if either function fails, the test should throw an error. I am more than happy to remove them. Thoughts?

Copy link
Contributor

@cjihrig cjihrig Dec 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, on second though, these aren't needed. common.mustCall() isn't really necessary with any synchronous code.

Copy link
Contributor Author

@radelmann radelmann Dec 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks for the input. I'll remove.

@santigimeno
Copy link
Member

santigimeno commented Dec 8, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/5311/

@radelmann
test: refactor test-fs-fsync
f121377 
- replace var with const.
- remove successes var.
- use assert.ifError() for handling all errors.
- wrap all callbacks with common.mustCall().
@radelmann
Copy link
Contributor Author

radelmann commented Dec 13, 2016

Bump

@italoacasas
Copy link

italoacasas commented Dec 13, 2016

Landed 34991be

Thanks for the contribution

italoacasas pushed a commit that referenced this pull request Dec 13, 2016
@radelmann
test: refactor test-fs-fsync
34991be 
- replace var with const.
- remove successes var.
- use assert.ifError() for handling all errors.
- wrap all callbacks with common.mustCall().

PR-URL: #10176
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
AnnaMag pushed a commit to AnnaMag/node that referenced this pull request Dec 13, 2016
@radelmann @AnnaMag
test: refactor test-fs-fsync
c181228 
- replace var with const.
- remove successes var.
- use assert.ifError() for handling all errors.
- wrap all callbacks with common.mustCall().

PR-URL: nodejs#10176
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
evanlucas pushed a commit that referenced this pull request Dec 14, 2016
@radelmann @evanlucas
test: refactor test-fs-fsync
d5e30a6 
- replace var with const.
- remove successes var.
- use assert.ifError() for handling all errors.
- wrap all callbacks with common.mustCall().

PR-URL: #10176
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@italoacasas italoacasas mentioned this pull request Dec 15, 2016
Merged
targos pushed a commit that referenced this pull request Dec 28, 2016
@radelmann @targos
test: refactor test-fs-fsync
532415f 
- replace var with const.
- remove successes var.
- use assert.ifError() for handling all errors.
- wrap all callbacks with common.mustCall().

PR-URL: #10176
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 22, 2017
@radelmann @MylesBorins
test: refactor test-fs-fsync
b4879f8 
- replace var with const.
- remove successes var.
- use assert.ifError() for handling all errors.
- wrap all callbacks with common.mustCall().

PR-URL: #10176
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 22, 2017
@radelmann @MylesBorins
test: refactor test-fs-fsync
13a75dc 
- replace var with const.
- remove successes var.
- use assert.ifError() for handling all errors.
- wrap all callbacks with common.mustCall().

PR-URL: #10176
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
@radelmann @MylesBorins
test: refactor test-fs-fsync
6592a87 
- replace var with const.
- remove successes var.
- use assert.ifError() for handling all errors.
- wrap all callbacks with common.mustCall().

PR-URL: #10176
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
@radelmann @MylesBorins
test: refactor test-fs-fsync
cd2b32e 
- replace var with const.
- remove successes var.
- use assert.ifError() for handling all errors.
- wrap all callbacks with common.mustCall().

PR-URL: #10176
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
This was referenced Jan 24, 2017
Merged
Merged
MylesBorins pushed a commit that referenced this pull request Jan 31, 2017
@radelmann @MylesBorins
test: refactor test-fs-fsync
217e2c6 
- replace var with const.
- remove successes var.
- use assert.ifError() for handling all errors.
- wrap all callbacks with common.mustCall().

PR-URL: #10176
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 1, 2017
@radelmann @MylesBorins
test: refactor test-fs-fsync
730c3b2 
- replace var with const.
- remove successes var.
- use assert.ifError() for handling all errors.
- wrap all callbacks with common.mustCall().

PR-URL: #10176
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrig cjihrig cjihrig approved these changes

@santigimeno santigimeno santigimeno approved these changes

+2 more reviewers

@thefourtheye thefourtheye thefourtheye approved these changes

@italoacasas italoacasas italoacasas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@radelmann @santigimeno @italoacasas @thefourtheye @cjihrig @mscdex @MylesBorins @targos @nodejs-github-bot