test: polish test-net-better-error-messages-listen#10087
Closed
digitalinfinity wants to merge 1 commit intonodejs:masterfrom
Closed
test: polish test-net-better-error-messages-listen#10087digitalinfinity wants to merge 1 commit intonodejs:masterfrom
digitalinfinity wants to merge 1 commit intonodejs:masterfrom
Conversation
Cleans up test-net-better-error-messages-list.js with following: - var -> cons - assert.equal -> assert.strictEqual
evanlucas
suggested changes
Dec 2, 2016
Contributor
evanlucas
left a comment
evanlucas
left a comment
There was a problem hiding this comment.
The code looks good, but there is a typo in the commit message:
- var -> cons should be - var -> const
addaleax
approved these changes
Dec 2, 2016
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
LGTM with @evanlucas’ nit (can also be done when landing)
cjihrig
approved these changes
Dec 2, 2016
targos
approved these changes
Dec 2, 2016
Member
|
Landed in 6d54c87, thanks for the contribution! |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 4, 2016
Cleans up test-net-better-error-messages-list.js with following: - var -> const - assert.equal -> assert.strictEqual PR-URL: nodejs#10087 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
addaleax
pushed a commit
that referenced
this pull request
Dec 5, 2016
Cleans up test-net-better-error-messages-list.js with following: - var -> const - assert.equal -> assert.strictEqual PR-URL: #10087 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
Cleans up test-net-better-error-messages-list.js with following: - var -> const - assert.equal -> assert.strictEqual PR-URL: nodejs#10087 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
jmdarling
pushed a commit
to jmdarling/node
that referenced
this pull request
Dec 8, 2016
Cleans up test-net-better-error-messages-list.js with following: - var -> const - assert.equal -> assert.strictEqual PR-URL: nodejs#10087 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 20, 2016
Cleans up test-net-better-error-messages-list.js with following: - var -> const - assert.equal -> assert.strictEqual PR-URL: #10087 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
Cleans up test-net-better-error-messages-list.js with following: - var -> const - assert.equal -> assert.strictEqual PR-URL: #10087 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
Cleans up test-net-better-error-messages-list.js with following: - var -> const - assert.equal -> assert.strictEqual PR-URL: #10087 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
Cleans up test-net-better-error-messages-list.js with following: