test: test-https-truncate.js - assert.equal -> assert.strictEqual, var -> const/let#10074
Closed
davidmarkclements wants to merge 1 commit intonodejs:masterfrom
davidmarkclements:test-https-truncate-patch
Closed
test: test-https-truncate.js - assert.equal -> assert.strictEqual, var -> const/let#10074davidmarkclements wants to merge 1 commit intonodejs:masterfrom davidmarkclements:test-https-truncate-patch
davidmarkclements wants to merge 1 commit intonodejs:masterfrom
davidmarkclements:test-https-truncate-patch
Conversation
Member
|
LGTM with the commit message following the contributing guideline. |
cjihrig
approved these changes
Dec 1, 2016
Contributor
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
LGTM with a fixed commit message.
davidmarkclements
changed the title
changes assert.equal to assert.strictEqual to ensure specificity changes var declarations to const/let where appropriate
addaleax
added
the
code-and-learn
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 5, 2016
Changes assert.equal to assert.strictEqual to ensure specificity. Changes var declarations to const/let where appropriate. PR-URL: nodejs#10074 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Member
|
Landed in a6ddd57. Thanks for the contribution! 🎉 |
Fishrock123
pushed a commit
that referenced
this pull request
Dec 5, 2016
Changes assert.equal to assert.strictEqual to ensure specificity. Changes var declarations to const/let where appropriate. PR-URL: #10074 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
Changes assert.equal to assert.strictEqual to ensure specificity. Changes var declarations to const/let where appropriate. PR-URL: nodejs#10074 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
jmdarling
pushed a commit
to jmdarling/node
that referenced
this pull request
Dec 8, 2016
Changes assert.equal to assert.strictEqual to ensure specificity. Changes var declarations to const/let where appropriate. PR-URL: nodejs#10074 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 20, 2016
Changes assert.equal to assert.strictEqual to ensure specificity. Changes var declarations to const/let where appropriate. PR-URL: #10074 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
Changes assert.equal to assert.strictEqual to ensure specificity. Changes var declarations to const/let where appropriate. PR-URL: #10074 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
Changes assert.equal to assert.strictEqual to ensure specificity. Changes var declarations to const/let where appropriate. PR-URL: #10074 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test, https
Description of change
changes assert.equal to assert.strictEqual to ensure specificity
changes var declarations to const/let where appropriate
edit: correct subsystem