test: update var to let/const and replace arbitrary timeout.#10064
Closed
cByst wants to merge 1 commit intonodejs:masterfrom
Closed
test: update var to let/const and replace arbitrary timeout.#10064cByst wants to merge 1 commit intonodejs:masterfrom
cByst wants to merge 1 commit intonodejs:masterfrom
Conversation
cjihrig
approved these changes
Dec 1, 2016
Contributor
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
LGTM if the CI is happy.
julianduque
added
code-and-learn
addaleax
approved these changes
Dec 2, 2016
Member
gibfahn
suggested changes
Dec 2, 2016
Member
There was a problem hiding this comment.
Could you fix your commit message so that it complies with the contributing guidelines?
I suggest something like:
test: update test-tls-destroy-whilst-write
Update var to let/const and replace arbitrary timeout
If you amend your commit and push to your branch it will update the pull request.
git checkout test-tls-destroy-whilst-write
git commit --amend
git push --force-with-lease origin test-tls-destroy-whilst-writeOtherwise LGTM
Update var to let/const and replace arbitrary timeout
cByst
force-pushed
the
test-tls-destroy-whilst-write
branch
from
2ce6510 to
2dcc575
Compare
Contributor
Author
|
Updated the commit message to your suggestion. Lemme know if that looks good. Thanks! |
gibfahn
approved these changes
Dec 3, 2016
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 5, 2016
Update var to let/const and replace arbitrary timeout. PR-URL: nodejs#10064 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Member
|
Landed in 5e5ec12. |
Fishrock123
pushed a commit
that referenced
this pull request
Dec 5, 2016
Update var to let/const and replace arbitrary timeout. PR-URL: #10064 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
Update var to let/const and replace arbitrary timeout. PR-URL: nodejs#10064 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
jmdarling
pushed a commit
to jmdarling/node
that referenced
this pull request
Dec 8, 2016
Update var to let/const and replace arbitrary timeout. PR-URL: nodejs#10064 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 20, 2016
Update var to let/const and replace arbitrary timeout. PR-URL: #10064 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
Update var to let/const and replace arbitrary timeout. PR-URL: #10064 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
Update var to let/const and replace arbitrary timeout. PR-URL: #10064 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Test
Description of change
Updated variable declarations to const/let where possible.
Removed arbitrary timeout and replaced it with setImmediate()