test: add test for url module domainToAscii and domainToUnicode#10031
Closed
DarylThayil wants to merge 3 commits intonodejs:masterfrom
DarylThayil:domain-to-ascii-unicode
Closed
test: add test for url module domainToAscii and domainToUnicode#10031DarylThayil wants to merge 3 commits intonodejs:masterfrom DarylThayil:domain-to-ascii-unicode
DarylThayil wants to merge 3 commits intonodejs:masterfrom
DarylThayil:domain-to-ascii-unicode
Conversation
Member
|
/cc @jasnell |
Member
jasnell
requested changes
Dec 5, 2016
Member
jasnell
left a comment
There was a problem hiding this comment.
Almost there. Just needs one small fix
| ['भारत.org', 'xn--h2brj9c.org'] | ||
| ]; | ||
|
|
||
| domainWithASCII.forEach(pair => { |
Member
There was a problem hiding this comment.
Please wrap the pair in parens to match the common style
Author
|
@jasnell updated, how to i kick off ci again ? |
Member
|
Still getting some linting issues... |
Author
|
okay cool, ill make sure and run lint from now on thanks, will update |
jasnell
approved these changes
Dec 6, 2016
Member
Member
|
CI is ✅ |
jasnell
pushed a commit
that referenced
this pull request
Dec 6, 2016
PR-URL: #10031 Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in f8e07d0. Thank you for the PR and for participating in the code-and-learn! |
Fishrock123
pushed a commit
that referenced
this pull request
Dec 6, 2016
PR-URL: #10031 Reviewed-By: James M Snell <jasnell@gmail.com>
jmdarling
pushed a commit
to jmdarling/node
that referenced
this pull request
Dec 8, 2016
PR-URL: nodejs#10031 Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
Tests
Description of change
Added tests for url.URL.domainToASCII and url.URL.domainToUnicode with see data that transforms one way, and checks, then transform backwards and checks for strictEqual