Closed
Conversation
Member
|
@michael6 May I kindly ask you to format the commit message as described in CONTRIBUTING guidelines. |
imyller
added
code-and-learn
mhdawson
reviewed
Dec 3, 2016
Member
mhdawson
left a comment
mhdawson
left a comment
There was a problem hiding this comment.
Changes look ok but commit message needs to follow guidelines as suggested. Specifically, starting with "test:' in this case.
cjihrig
requested changes
Dec 3, 2016
test/parallel/test-crypto-ecb.js
Outdated
Trott
reviewed
Dec 4, 2016
test/parallel/test-crypto-ecb.js
Outdated
Trott
reviewed
Dec 4, 2016
test/parallel/test-crypto-ecb.js
Outdated
Member
There was a problem hiding this comment.
It would seem that const would be fine for this one too.
Member
cjihrig
approved these changes
Dec 4, 2016
addaleax
approved these changes
Dec 5, 2016
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 5, 2016
* var -> const/let * IIFE to blocks PR-URL: nodejs#10029 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Member
|
Landed in 11b3462. |
Fishrock123
pushed a commit
that referenced
this pull request
Dec 5, 2016
* var -> const/let * IIFE to blocks PR-URL: #10029 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
* var -> const/let * IIFE to blocks PR-URL: nodejs#10029 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
jmdarling
pushed a commit
to jmdarling/node
that referenced
this pull request
Dec 8, 2016
* var -> const/let * IIFE to blocks PR-URL: nodejs#10029 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 20, 2016
* var -> const/let * IIFE to blocks PR-URL: #10029 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
* var -> const/let * IIFE to blocks PR-URL: #10029 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
* var -> const/let * IIFE to blocks PR-URL: #10029 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
change var to const/let and equal to strictEqual.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change