es6 modification and include error message#10016
es6 modification and include error message#10016christyleung1987 wants to merge 1 commit intonodejs:masterfrom
Conversation
imyller
added
the
code-and-learn
mscdex
added
the
lib / src
There was a problem hiding this comment.
Sorry, the snippet explaining the task probably should have been a bit more precise on what to do here – This function won’t be called with err and cb arguments.
assert.throws takes a second argument that can be a regexp and validates the error message against that (like this). Do you think you could update this PR with that?
There was a problem hiding this comment.
ack, working on this now
There was a problem hiding this comment.
Ping @christyleung1987: Still working on this? (If you have any questions or need additional assistance, feel free to ask here or on the #node-dev channel on Freenode IRC.)
|
@christyleung1987 I took the liberty of making the change requested by @addaleax and pushing it to your branch. Hope that's OK! If some reviewers could please take a look, that would be great! |
|
Hi all, Sorry for the late reply, I didn't mean to ignore the messages, but I got the flu and strap throat at the same time and I'm still trying to recover from it. This has been a really great learning experience. |
* var -> const * add RegExp to assert.throws() to check error message PR-URL: nodejs#10016 Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in c00f647. |
* var -> const * add RegExp to assert.throws() to check error message PR-URL: #10016 Reviewed-By: James M Snell <jasnell@gmail.com>
* var -> const * add RegExp to assert.throws() to check error message PR-URL: #10016 Reviewed-By: James M Snell <jasnell@gmail.com>
* var -> const * add RegExp to assert.throws() to check error message PR-URL: #10016 Reviewed-By: James M Snell <jasnell@gmail.com>
10 participants
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Description of change