Defining OPENSSL_THREADS in common.gypi broke my Electron native addon build

[murgatroid99]

Change #23426 added a section to common.gypi that conditionally defines OPENSSL_THREADS. This change was integrated into Electron 5 and as a result my native addon that depends on BoringSSL under Electron now fails to build under Electron 5 with the following error message:

../deps/grpc/third_party/boringssl/include/openssl/base.h:143:0: error: "OPENSSL_THREADS" redefined [-Werror]
 #define OPENSSL_THREADS

The full bug details are at electron/electron#18122.

[refack]

Hello @murgatroid99 and thank you for the report. You can un-define this macro in your binding.gyp, using GYP's exclude-from-list ! suffix:

   'defines!': [ 'OPENSSL_THREADS' ],

P.S. Or follow the suggestions in electron/electron#18122 (comment)

[bnoordhuis]

I'll close this out as a workaround exists and I don't think it's a change we'll roll back. Without exporting OPENSSL_THREADS you can't use some APIs from openssl/crypto.h safely or at all.