lint-md on master failing

[devsnek]

errors look like:

<filename>.md
  1:1  error  Error: Cannot parse file `.remarkrc`
Cannot parse script `tools/remark-preset-lint-node/index.js`
Error: Cannot find module 'remark-lint-maximum-line-length'
    at Function.Module._resolveFilename (module.js:559:15)
    at Function.Module._load (module.js:486:25)
    at Module.require (module.js:614:17)
    at require (internal/module.js:20:18)
    at Object.<anonymous> (tools/remark-preset-lint-node/index.js:53:4)
    at Module._compile (module.js:666:30)
    at Object.Module._extensions..js (module.js:677:10)
    at Module.load (module.js:577:32)
    at tryModuleLoad (module.js:517:12)
    at Function.Module._load (module.js:509:3)
    at FormattedError (tools/remark-cli/node_modules/fault/index.js:30:12)
    at done (tools/remark-cli/node_modules/unified-engine/lib/find-up.js:143:22)
    at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:437:3)

clearing node_modules for the remark deps and re-installing yields the following diff and things work again:

diff --git a/tools/remark-cli/package-lock.json b/tools/remark-cli/package-lock.json
index e47a22823d..f8ed41f779 100644
--- a/tools/remark-cli/package-lock.json
+++ b/tools/remark-cli/package-lock.json
@@ -2,7 +2,6 @@
   "name": "remark-cli",
   "version": "4.0.0",
   "lockfileVersion": 1,
-  "preserveSymlinks": "1",
   "requires": true,
   "dependencies": {
     "ansi-regex": {

should this be pr'd or is something else not right

[ChALkeR]

@devsnek The "preserveSymlinks": "1" line is not the culprit.

make lint-md-build seems to be not re-run automatically on remark-preset-lint-node update.

So after a29089d, make lint-md-build should have been forced to run locally to install the new dep (see a29089d#diff-1b5e63f4adfa8852dadb8af51b571647R35), but it wasn't for some reason. Probably proper makefile deps can fix this.

[SirR4T]

Stumbled into this, when running make -j4 test on master.
For anyone else: do run make lint-md-build, before running the above, to install required tools.

@ChALkeR Good idea to make the lint-md-build a dependency for test target in Makefile? Or is that too much?

[richardlau]

Good idea to make the lint-md-build a dependency for test target in Makefile? Or is that too much?

#18981 (comment)

[SirR4T]

ah! Thanks!