This repository was archived by the owner on Feb 1, 2022. It is now read-only.
Address regressions due to changes in node#67
Merged
Conversation
0fba6a0 to
cc4da57
Compare
cc4da57 to
5b3511e
Compare
Collaborator
Author
|
Both |
Collaborator
Author
|
/cc @nodejs/diagnostics |
Collaborator
Author
|
This seems like a good opportunity to a) enable these tests in the node CI runs and/or b) update the status of |
bnoordhuis
approved these changes
Jun 2, 2019
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To clean up the breakpoint matching, I pulled that regex into a dedicated helper in the test harness for launching the CLI.