fix: allow opt-out of Fixes/Refs metadata#474
Merged
codebytere merged 2 commits intonodejs:masterfrom Aug 15, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #474 +/- ##
=======================================
Coverage 82.58% 82.59%
=======================================
Files 34 34
Lines 1665 1660 -5
=======================================
- Hits 1375 1371 -4
+ Misses 290 289 -1
Continue to review full report at Codecov.
|
codebytere
force-pushed
the
fixes-refs-opt-out
branch
from
0dc64de to
c429b45
Compare
richardlau
reviewed
Aug 14, 2020
Member
richardlau
left a comment
richardlau
left a comment
There was a problem hiding this comment.
Change looks okay but needs tests.
richardlau
approved these changes
Aug 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #470.
Allows for a collaborator to skip
Fixes:andRefs:being automatically added to generated commit metadata if--skipRefsis passed.