This repository was archived by the owner on Oct 15, 2020. It is now read-only.
Merged
Conversation
Contributor
Author
MSLaguana
approved these changes
Sep 6, 2018
Contributor
Author
|
The CI fails due to another fix I'm trying to land upstream: nodejs/node#22721 Once that lands I'll cherry-pick it here. I've already tested locally and Linux build/test run passes with both changes. |
* Added `#include <vector>` to fix a build break on Linux * Fixed test lint issues (line and indents mostly) * Fixed options lint issues and added the help text back PR-URL: nodejs#588 Reviewed-By: Seth Brenith <sethb@microsoft.com> Reviewed-By: Jimmy Thomson <jithomso@microsoft.com>
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
Sep 10, 2018
* Added `#include <vector>` to fix a build break on Linux * Fixed test lint issues (line and indents mostly) * Fixed options lint issues and added the help text back PR-URL: nodejs#588 Reviewed-By: Seth Brenith <sethb@microsoft.com> Reviewed-By: Jimmy Thomson <jithomso@microsoft.com>
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
Sep 11, 2018
* Added `#include <vector>` to fix a build break on Linux * Fixed test lint issues (line and indents mostly) * Fixed options lint issues and added the help text back PR-URL: nodejs#588 Reviewed-By: Seth Brenith <sethb@microsoft.com> Reviewed-By: Jimmy Thomson <jithomso@microsoft.com>
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
Oct 3, 2018
* Added `#include <vector>` to fix a build break on Linux * Fixed test lint issues (line and indents mostly) * Fixed options lint issues and added the help text back PR-URL: nodejs#588 Reviewed-By: Seth Brenith <sethb@microsoft.com> Reviewed-By: Jimmy Thomson <jithomso@microsoft.com>
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
Oct 3, 2018
* Added `#include <vector>` to fix a build break on Linux * Fixed test lint issues (line and indents mostly) * Fixed options lint issues and added the help text back PR-URL: nodejs#588 Reviewed-By: Seth Brenith <sethb@microsoft.com> Reviewed-By: Jimmy Thomson <jithomso@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#include <vector>to fix a build break on LinuxChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passes