Add test coverage for typed and range err#1280
Merged
JckXia merged 7 commits intonodejs:mainfrom Mar 17, 2023
Merged
Conversation
Member
|
I'd suggest avoiding type checks in type wrapper constructors for the following reasons:
Instead, I'd suggest adopting the approach introduced in #1281, allowing people to opt-in for the type check. |
Member
Author
|
@legendecas Thank you for your explanation! Will update my changes. |
f4a835b to
2968cf0
Compare
legendecas
reviewed
Feb 7, 2023
legendecas
approved these changes
Mar 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR aims to close #981, #984 and #1271.
Adds test for
TypeErrorandRangeError, as well as some validation logic for thenapi_valueobject we pass to the baseTypeErrorandRangeErrorctor. The question is whether we want to crash the application when thenapi_valuepassed isn't a jsTypeError, or if we want to emit some type of warning instead.