Don't use deprecated v8::Template::Set()#559
Closed
mdouglass wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
Setting non-primitive values on FunctionTemplate and ObjectTemplate instances is depreciated.
Author
|
Likely an incomplete fix and I'm not sure if there are other backwards incompatibility issues that need to be addressed to complete this. It does, however, silence the warning for the simple case I've been testing with. |
Member
Author
|
No worries, looks like you're closing in on a better fix, I'll close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting non-primitive values on FunctionTemplate and ObjectTemplate
instances is depreciated.
Fixes #558