-
Notifications
You must be signed in to change notification settings - Fork 2k
Update architectures files (generated) #994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,8 @@ | ||
| bashbrew-arch variants | ||
| amd64 jessie,jessie-slim,alpine,stretch,stretch-slim | ||
| arm32v6 alpine | ||
| arm32v7 jessie,jessie-slim,onbuild,stretch,stretch-slim | ||
| arm64v8 alpine,onbuild,stretch | ||
| amd64 jessie,jessie-slim,alpine,onbuild,stretch,stretch-slim | ||
| arm32v7 jessie,jessie-slim,stretch,stretch-slim | ||
| arm64v8 alpine,stretch,stretch-slim | ||
| i386 alpine | ||
| ppc64le alpine,onbuild,stretch | ||
| s390x alpine,onbuild,stretch | ||
| ppc64le alpine,stretch,stretch-slim | ||
| s390x alpine,stretch,stretch-slim | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| bashbrew-arch variants | ||
| amd64 alpine,stretch,stretch-slim | ||
| arm32v6 alpine | ||
| arm32v7 stretch,stretch-slim | ||
| arm64v8 alpine,stretch,stretch-slim | ||
| i386 alpine | ||
| ppc64le alpine,stretch,stretch-slim | ||
| s390x alpine,stretch,stretch-slim | ||
LaurentGoderre marked this conversation as resolved.
Show resolved
Hide resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,8 @@ | ||
| bashbrew-arch variants | ||
| arm32v7 jessie,jessie-slim,onbuild,stretch,stretch-slim | ||
| arm64v8 stretch | ||
| amd64 jessie,jessie-slim,alpine,onbuild,stretch,stretch-slim | ||
| i386 jessie,jessie-slim,onbuild,stretch,stretch-slim | ||
| ppc64le stretch | ||
| s390x stretch | ||
| arm32v6 alpine | ||
| arm32v7 jessie,jessie-slim,onbuild,stretch,stretch-slim | ||
| arm64v8 alpine,onbuild,stretch,stretch-slim | ||
| i386 jessie,jessie-slim,alpine,onbuild,stretch,stretch-slim | ||
| ppc64le alpine,onbuild,stretch,stretch-slim | ||
| s390x alpine,onbuild,stretch,stretch-slim |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,8 @@ | ||
| bashbrew-arch variants | ||
| amd64 jessie,jessie-slim,alpine,onbuild,stretch,stretch-slim | ||
| arm32v6 alpine | ||
| arm32v7 jessie,jessie-slim,onbuild,stretch,stretch-slim | ||
| arm64v8 alpine,onbuild,stretch,stretch-slim | ||
| amd64 jessie,jessie-slim,alpine,onbuild,stretch,stretch-slim | ||
| i386 jessie,jessie-slim,alpine,onbuild,stretch,stretch-slim | ||
| ppc64le alpine,onbuild,stretch,stretch-slim | ||
| s390x alpine,onbuild,stretch,stretch-slim |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,8 @@ | ||
| bashbrew-arch variants | ||
| arm32v6 alpine | ||
| arm32v7 jessie,jessie-slim,onbuild,stretch,stretch-slim | ||
| arm64v8 alpine,onbuild,stretch,stretch-slim | ||
| amd64 jessie,jessie-slim,alpine,onbuild,stretch,stretch-slim | ||
| i386 alpine | ||
| ppc64le alpine,onbuild,stretch,stretch-slim | ||
| s390x alpine,onbuild,stretch,stretch-slim | ||
| arm32v6 jessie,jessie-slim,alpine,onbuild,stretch,stretch-slim | ||
| arm32v7 jessie,jessie-slim,alpine,onbuild,stretch,stretch-slim | ||
| arm64v8 jessie,jessie-slim,alpine,onbuild,stretch,stretch-slim | ||
| i386 jessie,jessie-slim,alpine,onbuild,stretch,stretch-slim | ||
| ppc64le jessie,jessie-slim,alpine,onbuild,stretch,stretch-slim | ||
| s390x jessie,jessie-slim,alpine,onbuild,stretch,stretch-slim |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this one different than all the other version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you check out https://nodejs.org/dist/latest-v10.x/, there's no
x86artifact anymore (#823), so only Alpine is supported there (since it builds from source).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, looking at the output of this:
I don't see it either for v10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, good to know!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to make sure, @MylesBorins @rvagg is this intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't even test Node on x86 Linux any more, it's marked "experimental" which means that our infra doesn't test for it, we don't build it but we'll accept community contributions for it. That leaves downstream packagers in an awkward position because you get less support.
I'd suggest that you should drop x86 from Docker. But it'd also be interesting to know what the x86 Docker userbase looks like. Do you have metrics that would indicate what the impact would be?
On another note, I'm pondering setting up an "alternative builds" project that's a little separate to the official Node build infrastructure and nodejs.org offerings. There's a few things that could be offloaded to it, Linux x86 and ARMv6 being the obvious two and Linux musl being a possible addition. We're trying hard to simplify our infra on the official Node end because it's been getting out of hand so setting up something on the side that's unofficial and maybe maintained by an entirely different set of people would be a positive step forward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^ I meant to add that I'd like to gauge interest in such a project and whether there'd be people here willing to contribute time and maybe organisations that might be willing to contribute $$ if needed.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm working on an "alternative" dist of linux/ia32 for the Internet Archive people. The idea is to have a best-effort-supported dist, and stop when it breaks or becomes intractable.
BTW their use case is embedded systems, so it's not obvious to me if that correlates with Docker use cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume that means "no binaries at all", there would still be binaries for Alpine even though we don't ship binaries for that on Nodejs.org, Right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I simply mean dropping things like x86/i386 which are no longer built for officially (even though Alpine images are built from source and could thus still be provided with 32bit builds).