You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This does not update Dockerfile-alpine.template, which means running update.sh will rollback the version in this dockerfile. Is that expected/wanted?
For the record (personal opinion, not WG policy) - the template should be updated, and update.sh without parameters should not be used, but only run with a specific version, like update.sh 8.0.
If the template is updated, that would mean node 4 and 6 would get the new alpine version.
When they see new releases, yes, that's a weakness in the current setup. They would require manual cleanup after update.sh then. Either that, or the current branch (8.x) would require manual fixing (present state). I think the better option is if the template matches the current branch, as it would see more frequent releases from now on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just 8.0, right?
This does not update
Dockerfile-alpine.template, which means runningupdate.shwill rollback the version in this dockerfile. Is that expected/wanted?