aix: set jenkins TERM to a consistent value#1822
Merged
sam-github merged 1 commit intonodejs:masterfrom Jun 10, 2019
sam-github:consistent-term-env
Merged
aix: set jenkins TERM to a consistent value#1822sam-github merged 1 commit intonodejs:masterfrom sam-github:consistent-term-env
sam-github merged 1 commit intonodejs:masterfrom
sam-github:consistent-term-env
Conversation
Contributor
Author
|
/to @richardlau |
richardlau
approved these changes
Jun 5, 2019
Currently, it is inherited from the user that started Jenkins, which can be `TERM=dumb` in some ssh environments. That value of TERM breaks some of the terminal related tests, so ensure a consistent TERM value. Fixes: nodejs/node#28064 PR-URL: #1822 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Contributor
Author
|
Fix manually applied to:
@mhdawson I do not have credentials to update release-osuosl-aix61-ppc64_be-1, you should look at it (assuming it runs the node test suite during the release proces). |
Member
|
@sam-github we don't run the test suite on the release machines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, it is inherited from the user that started Jenkins, which can
be
TERM=dumbin some ssh environments. That value of TERM breaks someof the terminal related tests, so ensure a consistent TERM value.
Fixes: nodejs/node#28064