Expunge obsolete optim code from codebase - #336
Merged
Merged
Conversation
Contributor
|
I'm not seeing where this broke in testing. the travis-CI report ends early but where is the failure? |
Contributor
Author
|
I think I accidentally cancelled the build. It looks like github doesn't display the difference between CANCEL and FAIL. So I just restarted the build. |
Contributor
|
Oh that makes sense. |
Contributor
|
Given that these are simple changes (removed old code) and testing runs longs, LGTM and we could go ahead with merge if we want to move quickly today. |
Contributor
Author
|
OK @perrydv , we should now be ready to merge |
Contributor
|
will do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes way for a clean reimplementation of
optimin #318