Skip to content

Ignore changes to codeStyles and stray files#3

Merged
MilosKozak merged 1 commit into
nightscout:devfrom
dlvoy:hotfix/ignoring-codestyles-changes
Sep 25, 2020
Merged

Ignore changes to codeStyles and stray files#3
MilosKozak merged 1 commit into
nightscout:devfrom
dlvoy:hotfix/ignoring-codestyles-changes

Conversation

@dlvoy

@dlvoy dlvoy commented Sep 24, 2020

Copy link
Copy Markdown
Contributor

When app is built from master branch, gradle checks if repository is clean and does not have uncommitted changes.
Unfortunately, some versions of Android Studio auto-magically update files inside .idea/codeStyle preventing user from building stable versions of app.

To prevent that, function that check if all changes are commited is extended to ignore:

  • all changes inside .idea/codeStyle
  • all new files not yet added/known to GIT

while still not allowing changes/staged additions to other parts of the code, if built from master

@codecov

codecov Bot commented Sep 24, 2020

Copy link
Copy Markdown

Codecov Report

Merging #3 into dev will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev       #3      +/-   ##
============================================
- Coverage     10.12%   10.12%   -0.01%     
+ Complexity     1092     1091       -1     
============================================
  Files           753      753              
  Lines         34725    34725              
  Branches       4895     4895              
============================================
- Hits           3517     3516       -1     
  Misses        30956    30956              
- Partials        252      253       +1     
Impacted Files Coverage Δ Complexity Δ
...a/info/nightscout/androidaps/utils/SntpClient.java 91.56% <0.00%> (-1.21%) 12.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb8203c...e1e0244. Read the comment docs.

@MilosKozak
MilosKozak merged commit 870c9bb into nightscout:dev Sep 25, 2020
kalleelmer referenced this pull request in kalleelmer/AndroidAPS Oct 6, 2020
extend pump interface for neutral temps
MilosKozak pushed a commit that referenced this pull request Dec 18, 2020
MilosKozak pushed a commit that referenced this pull request Feb 20, 2021
MilosKozak pushed a commit that referenced this pull request Nov 4, 2021
…sformation

events without reflection
Checked and it works 👍 
Thanks for the lesson
MilosKozak pushed a commit that referenced this pull request Feb 20, 2022
MilosKozak added a commit that referenced this pull request Sep 3, 2023
MilosKozak added a commit that referenced this pull request Nov 30, 2023
MilosKozak added a commit that referenced this pull request Jan 11, 2025
MilosKozak added a commit that referenced this pull request Apr 1, 2026
MilosKozak added a commit that referenced this pull request Apr 23, 2026
MilosKozak added a commit that referenced this pull request Jun 11, 2026
MilosKozak added a commit that referenced this pull request Jun 24, 2026
MilosKozak added a commit that referenced this pull request Jun 27, 2026
* UI tests

* UI tests #2

* UI tests #3

* UI tests #4

* UI tests #5

* UI tests #6
MilosKozak added a commit that referenced this pull request Jul 15, 2026
MilosKozak added a commit that referenced this pull request Jul 16, 2026
MilosKozak added a commit that referenced this pull request Jul 16, 2026
MilosKozak added a commit that referenced this pull request Jul 16, 2026
* Improve CI

* Improve CI #2

* Improve CI #3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants