vector_pop_value does not return a value

[lucaspalomodevelop]

Hi,
I noticed that the function vector_pop_value does not return a value, even though its signature suggests it should.

Reference:

DragonCompiler/helpers/vector.c

Line 308 in 74299a1

int vector_pop_value(struct vector* vector, void* val)

Expected behavior:
The function should return the popped value to the caller.

Actual behavior:
The function returns nothing (implicit void / missing return statement).

Suggested fix:
Add a return statement that returns the popped value.

[lucaspalomodevelop]

@nibblebits just wanted to make sure this is the right place to report this — the issue has been open for 2 weeks without a response. Please let me know if this should be moved to PeachCompiler or if any additional information is needed!

[nibblebits]

Hello,
This is the development repository before PeachCompiler existed is hthe same problem present in the course repository

Thanks
Daniel McCarthy

[nibblebits]

Just following up this function is designed to pop a particular value from the vector not to return the element with a given value

[nibblebits]

ahh i see what your talking about now yes it should return zero , or the index. Is the same mistake present in PeachCompiler? If so please make the issue there