Get system date/time without needing shell_exec()#448
Closed
joshtrichards wants to merge 1 commit intonextcloud:masterfrom
Closed
Get system date/time without needing shell_exec()#448joshtrichards wants to merge 1 commit intonextcloud:masterfrom
joshtrichards wants to merge 1 commit intonextcloud:masterfrom
Conversation
One less use of shell_exec(). Maintains same output format typically used by `date` so no changes needed elsewhere Relevant to nextcloud#169 and possibly nextcloud#347 Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
Collaborator
|
The linux command |
Member
Author
|
Oops completely overlooked that. Have a couple ideas. I'll try to take a look later in week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One less use of shell_exec(). Maintains same output format typically used by
dateso no changes needed elsewhere.Relevant to #169 and possibly #347.
It's also about 200x faster per call according to benchmarking via PHP's hrtime() on my test system, but that's 100% irrelevant unless one has a lot of admins checking their System info simultaneously. 😆