fix: Log exceptions that happen during file conversion#50227
Merged
juliusknorr merged 1 commit intomasterfrom Jan 17, 2025
Merged
fix: Log exceptions that happen during file conversion#50227juliusknorr merged 1 commit intomasterfrom
juliusknorr merged 1 commit intomasterfrom
Conversation
Signed-off-by: Julius Knorr <jus@bitgrid.net>
provokateurin
approved these changes
Jan 17, 2025
elzody
approved these changes
Jan 17, 2025
skjnldsv
reviewed
Jan 17, 2025
| use OCP\Files\IRootFolder; | ||
| use OCP\IL10N; | ||
| use OCP\IRequest; | ||
| use function OCP\Log\logger; |
Member
There was a problem hiding this comment.
Is this the new recommended way? 🙈
It looks so odd 😁
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logging the exception helps to figure out why a provider failed, also we should not expose internal exception messages as API response data.