fix(files): Use SVG as FilePicker buttons to bring back icons#41707
Merged
fix(files): Use SVG as FilePicker buttons to bring back icons#41707
Conversation
susnux
added
bug
3. to review
susnux
requested review from
AndyScherzinger,
Pytal,
artonge,
nfebe and
skjnldsv
susnux
force-pushed
the
fix/missing-icons-on-filepicker
branch
from
6bcc990 to
4d33fac
Compare
Contributor
Author
|
/backport to stable28 |
Pytal
approved these changes
Nov 23, 2023
AndyScherzinger
approved these changes
Nov 23, 2023
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
AndyScherzinger
force-pushed
the
fix/missing-icons-on-filepicker
branch
from
4d33fac to
faa2f2d
Compare
Contributor
Author
|
Cypress unrelated, see #41712 |
Contributor
|
"Neuer Ordner" does not have a icon as well - this is something different, right? |
Contributor
Author
Yes, that will be fixed with next dialog update. |
8 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The FilePicker does not allow components as icons anymore so use SVG's instead.
Screenshots
Checklist