Conversation
nfebe
force-pushed
the
26691-improve-sharing-design-flow
branch
4 times, most recently
from
7cf0c6c to
f1e8fda
Compare
nfebe
force-pushed
the
26691-improve-sharing-design-flow
branch
9 times, most recently
from
d0ab2b1 to
c10f540
Compare
Contributor
Author
Share Details View
|
AndyScherzinger
added
enhancement
design
This comment was marked as resolved.
This comment was marked as resolved.
nfebe
force-pushed
the
26691-improve-sharing-design-flow
branch
from
c10f540 to
c029526
Compare
jancborchardt
requested review from
marcoambrosini,
nimishavijay,
skjnldsv and
szaimen
nfebe
force-pushed
the
26691-improve-sharing-design-flow
branch
from
c029526 to
058db4c
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
nfebe
force-pushed
the
26691-improve-sharing-design-flow
branch
2 times, most recently
from
6e7f0d4 to
7df89e8
Compare
nfebe
force-pushed
the
26691-improve-sharing-design-flow
branch
from
5447239 to
7b3d0e1
Compare
Merged
artonge
reviewed
Aug 30, 2023
|
|
||
| <!-- share details --> | ||
| <div v-else> | ||
| <SharingDetailsTab :file-info="shareDetailsData.fileInfo" |
Contributor
There was a problem hiding this comment.
Any reason to use shareDetailsData.fileInfo instead of fileInfo ?
artonge
reviewed
Aug 30, 2023
| return null | ||
| } | ||
|
|
||
| const expirationTime = moment(this.share.passwordExpirationTime) |
Contributor
There was a problem hiding this comment.
You need to import moment.
import moment from "@nextcloud/moment"
3 tasks
artonge
reviewed
Aug 30, 2023
artonge
approved these changes
Aug 30, 2023
AndyScherzinger
approved these changes
Aug 30, 2023
artonge
dismissed stale reviews from jancborchardt and szaimen
Will be in a follow up if still relevent
nfebe
force-pushed
the
26691-improve-sharing-design-flow
branch
2 times, most recently
from
321e905 to
488dcfb
Compare
This commit introduces the following changes: - Does not create new share once user is selected for internal shares - Adds a `SharingDetails` view for share configurations - Adds a quick share select to enable fast changes in share permisions. Resolves: #26691 Signed-off-by: fenn-cs <fenn25.fn@gmail.com> Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge
added
3. to review
Contributor
|
Backport to stable27: #40166 |
artonge
force-pushed
the
26691-improve-sharing-design-flow
branch
from
488dcfb to
79f6263
Compare
23 tasks
Merged
4 tasks
6 tasks
7 tasks
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves: #26691