Remove version check for ancient libxml version#38077
Merged
provokateurin merged 1 commit intomasterfrom May 5, 2023
Merged
Conversation
edc8dcb to
9a26bc1
Compare
Member
Author
|
Looking at the code I was able to make it even easier since the version was used to parse and format it, but there is already a variable for the formatted version. |
Member
|
https://github.com/php/php-src/blob/master/ext/libxml/libxml.c#LL45C13-L45C34 hmm strange it's missing from the docs |
Contributor
|
Good finding 👍 I think it should also work to remove the check for libxml 2.7.0. |
kesselb
approved these changes
May 5, 2023
Member
Author
Haha ok then it's even easier :D |
9a26bc1 to
009c396
Compare
blizzz
approved these changes
May 5, 2023
Signed-off-by: jld3103 <jld3103yt@gmail.com>
009c396 to
04d8402
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
New error with psalm 5.
With
LIBXML_LOADED_VERSIONI getCannot perform a numeric operation with a non-numeric type '21004-GITv2.10.4'.Looking at https://www.php.net/manual/en/libxml.constants.php it's not even documented...
EDIT: This version is so old that we can just remove this check.
Checklist