docs: document types flag for search options#35632
Merged
Conversation
juliusknorr
approved these changes
Dec 7, 2022
come-nc
approved these changes
Dec 8, 2022
Member
|
/rebase |
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
819eb6c to
ffb76d5
Compare
Contributor
Author
|
/backport to stable25 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Psalm warning for Mail:
ERROR: InvalidArgument - lib/Service/ContactsIntegration.php:183:59 - Argument 3 of OCP\Contacts\IManager::search expects array{enumeration?: bool, escape_like_param?: bool, fullmatch?: bool, limit?: int, offset?: int, strict_search?: bool}, but array{limit: 1, types: true} with additional array shape fields (types) was provided (see https://psalm.dev/004)$result = $this->contactsManager->search($uid, ['UID'], ['types' => true, 'limit' => 1]);server/lib/public/IAddressBook.php
Lines 61 to 80 in 2e0d262
The documentation for IAdressBook is up-to-date.
OCP\Contacts\IManager misses the
typessearch options flag.TODO
Checklist