[stable24] Validate custom dashboard background image#32791
Merged
Conversation
Signed-off-by: Christopher Ng <chrng8@gmail.com>
backportbot-nextcloud
bot
requested review from
CarlSchwan,
Pytal,
come-nc,
juliusknorr and
skjnldsv
skjnldsv
approved these changes
Jun 10, 2022
PVince81
requested changes
Jun 10, 2022
Member
PVince81
left a comment
PVince81
left a comment
There was a problem hiding this comment.
don't call fopen() twice, it will cause extra overhead on external storages that will then download the file twice (or at least create two http connections)
see https://github.com/nextcloud/server/blob/master/apps/files_external/lib/Lib/Storage/AmazonS3.php#L487 and https://github.com/nextcloud/server/blob/master/lib/private/Files/ObjectStore/S3ObjectTrait.php#L79 for example
@Pytal please fix the original PR and then apply the change to the backports
Member
blizzz
added
2. developing
Member
|
moving to 24.0.3 |
Merged
Pytal
force-pushed
the
backport/32675/stable24
branch
from
b5b72b5 to
59ca793
Compare
blizzz
approved these changes
Jun 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #32675