Allow compatibility wrapper on local external storage#32152
Merged
Conversation
The check was likely in place to prevent adding the wrapper on the root and home storage, which is not possible anyway since the encoding option cannot be set on that mount. Signed-off-by: Vincent Petry <vincent@nextcloud.com>
8 tasks
Member
Author
|
/backport to stable24 |
Member
Author
|
/backport to stable23 |
Member
Author
|
/backport to stable22 |
come-nc
approved these changes
Apr 26, 2022
artonge
approved these changes
Apr 26, 2022
Contributor
Are you sure? What about adding an external storage as root storage? |
PVince81
deleted the
bugfix/32151/allow-compatibility-wrapper-local-ext-storage
branch
|
The backport to stable23 failed. Please do this backport manually. |
|
The backport to stable22 failed. Please do this backport manually. |
Member
Author
I always forget this weird use case but not directly related as mounting an ext storage on top of the root just hides the root and the above was more about the fact that the actual root's settings aren't configurable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The check was likely in place to prevent adding the wrapper on the root
and home storage, which is not possible anyway since the encoding option cannot
be set on that mount.
Fixes #32151