Skip to content

Profile page#28751

Merged
Pytal merged 4 commits intomasterfrom
feat/28139/profile-page
Oct 19, 2021
Merged

Profile page#28751
Pytal merged 4 commits intomasterfrom
feat/28139/profile-page

Conversation

@Pytal
Copy link
Member

@Pytal Pytal commented Sep 7, 2021 •
edited
Loading

Tasks

  • Profile info and actions
    • Represent the info that is already set (DisplayName, Address, Avatar)
    • Required Profile actions
      • Account property actions (Email, Phone number, Website, Twitter)
      • Apps can register actions
      • Additional email actions
        • Order and scope of additional emails are not preserved, the logic for handling this is a prerequisite as visibility must also be preserved
    • Profile manager
      • Provide actions
      • Provide profile info
    • Privacy
      • Profile visibility
      • Respect already set scope settings
    • Display user status
  • Add new fields
    • Enable Profile checkbox (enabled by default)
      • Show error page when navigating to a disabled profile page
      • Don't show profile entrypoints when disabled
    • Organisation
    • Role
    • Biography
    • Headline
  • Profile entrypoints
    • Add entrypoint to your own profile in top-right user menu
    • Add profile preview card to personal info settings page
    • Add profile entrypoint to contacts menu as action and displayname link
    • Add profile entrypoint to Avatar menu through contacts menu actions provider (propagates to everything which uses ContactsMenuController)
  • Theming and dark mode work
  • Add necessary overrides (e.g. custom components, CSS overrides) for required functionality and UX
  • Make fields changes reactive (i.e. displayname, organisation, and profile enabled state changes are reflected instantly without needing a page reload)
  • Make it all look nice and work nicely together
  • Fix CI errors
  • Cleanup

Visual Reference

Profile page

image

Settings page

settings

Contributes to #28139

@Pytal Pytal added the 2. developing Work in progress label Sep 7, 2021
@Pytal Pytal added this to the Nextcloud 23 milestone Sep 7, 2021
@Pytal Pytal self-assigned this Sep 7, 2021
@Pytal Pytal marked this pull request as draft September 7, 2021 14:11
@Pytal Pytal force-pushed the feat/28139/profile-page branch 2 times, most recently from 70633d6 to 9f313bb Compare September 7, 2021 15:03
@Pytal Pytal mentioned this pull request Sep 7, 2021
Open
20 tasks
@Pytal Pytal force-pushed the feat/28139/profile-page branch 3 times, most recently from a7799d5 to db62eb4 Compare September 10, 2021 00:41
@Pytal Pytal added enhancement feature: settings feature: users and groups design Design, UI, UX, etc. feature: vue apps feature: profile PRs or issues related to the Profile feature (e.g. Profile page, API, etc.) labels Sep 10, 2021
@Pytal Pytal force-pushed the feat/28139/profile-page branch 8 times, most recently from e3f286d to ae3fe4d Compare September 17, 2021 21:32
@Pytal Pytal force-pushed the feat/28139/profile-page branch 5 times, most recently from a47399e to 3aaadbf Compare September 25, 2021 02:07
@Pytal Pytal force-pushed the feat/28139/profile-page branch from 3aaadbf to 31f7f14 Compare September 30, 2021 03:29
@skjnldsv skjnldsv requested a review from PVince81 October 15, 2021 17:51
@Pytal Pytal force-pushed the feat/28139/profile-page branch 4 times, most recently from 6985536 to 4bfa68f Compare October 15, 2021 19:25
@nickvergessen nickvergessen mentioned this pull request Oct 15, 2021
Merged
@Pytal Pytal force-pushed the feat/28139/profile-page branch from f70d6f2 to 4ed65c1 Compare October 15, 2021 19:43
@Pytal
Copy link
Member Author

Pytal commented Oct 15, 2021

/compile amend /

@Pytal @skjnldsv
Add profile templates
382ba66 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@skjnldsv skjnldsv force-pushed the feat/28139/profile-page branch from 37983b7 to 727250a Compare October 18, 2021 07:00
@skjnldsv
Copy link
Member

skjnldsv commented Oct 18, 2021

/compile amend /

nickvergessen
nickvergessen reviewed Oct 18, 2021
View reviewed changes
lib/private/Profile/Actions/EmailAction.php
if (empty($this->value)) {
return null;
}
return 'mailto:' . $this->value;
Copy link
Member

@nickvergessen nickvergessen Oct 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per @tobiasKaminsky this will make sure the profiles API needs a rewrite when we want to bring all the actions to the clients. We should return the bare values and the rendering should make it a link or something like that?

blizzz
blizzz reviewed Oct 18, 2021
View reviewed changes
@Pytal Pytal force-pushed the feat/28139/profile-page branch 3 times, most recently from 1310e35 to f85cf8f Compare October 18, 2021 20:49
ChristophWurst
ChristophWurst approved these changes Oct 18, 2021
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed public API part and give it a smoke test

👍 :shipit:

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 18, 2021
Pytal added 3 commits October 19, 2021 04:44
@Pytal
Add new account properties
7215148 
- New properties
  - Organisation
  - Role
  - Headline
  - Biography
  - Profile Enabled property
- Fix errors with building default account properties
- Fix L10N factory method `getLanguage` not public error
- Update tests

Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Profile backend
3093548 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Profile frontend
3be9d3c 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@skjnldsv skjnldsv mentioned this pull request Oct 19, 2021
Closed
@MichaIng MichaIng mentioned this pull request Nov 12, 2021
Merged
@ChristophWurst ChristophWurst mentioned this pull request Dec 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@blizzz blizzz blizzz left review comments

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@artonge artonge Awaiting requested review from artonge

@julien-nc julien-nc Awaiting requested review from julien-nc

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@come-nc come-nc Awaiting requested review from come-nc

@PVince81 PVince81 Awaiting requested review from PVince81

Assignees

@Pytal Pytal

Labels

4. to release Ready to be released and/or waiting for tests to finish design Design, UI, UX, etc. enhancement feature: profile PRs or issues related to the Profile feature (e.g. Profile page, API, etc.) feature: settings feature: users and groups feature: vue apps

Projects

None yet

Milestone

Nextcloud 23

Development

Successfully merging this pull request may close these issues.

6 participants

@Pytal @nickvergessen @skjnldsv @PVince81 @ChristophWurst @blizzz