Change the route generation of AuthPublicShareController.php#19478
Change the route generation of AuthPublicShareController.php#19478rullzer merged 2 commits intonextcloud:masterfrom Tim-Obert:bug/19475/fix-routes-generation-authpublicsharecontroller
Conversation
…st the routes for file sharing Signed-off-by: Tim Obert <tobert@w-commerce.de>
|
And then use routes: |
Signed-off-by: Tim Obert <tobert@w-commerce.de>
|
cc @Rello weren't you also doing things with this Controller? |
| return $app . '.' . $class . '.' . $function; | ||
| $class = (new \ReflectionClass($this))->getShortName(); | ||
| if ($this->appName === 'files_sharing') { | ||
| $class = strtolower($class); |
There was a problem hiding this comment.
right because we do nasty things in core.
Lets do this for now and at some poitn make sure that we fix those share routes.
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
|
Good stuff thanks for all the work @Tim-Obert |
|
/backport to stable18 |
|
/backport to stable17 |
|
backport to stable18 in #19610 |
|
backport to stable17 in #19611 |
closes #19475
Signed-off-by: Tim Obert tobert@w-commerce.de