Listen for event during preview rendering and apply secure view options#2579
Merged
juliusknorr merged 2 commits intomasterfrom Oct 26, 2022
Merged
Listen for event during preview rendering and apply secure view options#2579juliusknorr merged 2 commits intomasterfrom
juliusknorr merged 2 commits intomasterfrom
Conversation
juliusknorr
force-pushed
the
bugfix/watermark-preview
branch
3 times, most recently
from
0c1eaa2 to
4970eb1
Compare
Signed-off-by: Julius Härtl <jus@bitgrid.net>
…me infos Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
bugfix/watermark-preview
branch
from
4970eb1 to
fc9cbbd
Compare
Raudius
approved these changes
Oct 26, 2022
Contributor
Raudius
left a comment
Raudius
left a comment
There was a problem hiding this comment.
LGTM :)
Only thing I noticed is that you close a read-only watermarked file, you get a pretty bare view.
Screenshot:
Might be something to look into with the design team after this PR is merged :)
Member
Author
|
Let me actually have a look at that, because closing is something we can probably disable in the collabora view :) |
Member
Author
|
Might need some extra backend handling to hand over if we are on a single or folder share, will open a follow up issue for that. |
Member
Author
|
/backport to stable25 |
Member
Author
|
/backport to stable24 |
1 task
1 task
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary