fix: change status code from 404 to 204 for missing avatars#10694
Merged
fix: change status code from 404 to 204 for missing avatars#10694
Conversation
Switching the response code from 404 to 204 improves compatibility with security appliances like CrowdSec. Since avatar lookups (including external sources) can validly result in a non-existing avatar. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
SebastianKrupinski
approved these changes
Feb 14, 2025
Contributor
This will be such a nice improvement!!! |
ChristophWurst
approved these changes
Feb 14, 2025
Contributor
Author
|
/backport to stable4.2 |
Contributor
Author
|
/backport to stable4.1 |
Contributor
Author
|
/backport to stable3.7 |
This was referenced Feb 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to nextcloud/contacts#3021 and nextcloud/server#49839.
Switching the response code from 404 to 204 improves compatibility with security appliances like CrowdSec.
Since avatar lookups (including external sources) can validly result in a non-existing avatar.
Bonus: This will not trigger the debug log for missing avatars anylonger.
mail/src/components/Avatar.vue
Line 62 in bcd5239
There's another action in the controller also using 404.
I'm not sure where we are using it and therefore left it unchanged:
mail/lib/Controller/AvatarsController.php
Line 106 in bcd5239