Skip to content

Update signature of Entity::markFieldUpdated#4398

Merged
nickvergessen merged 1 commit intomainfrom
techdebt/noid/update-signature-of-markFieldUpdated
Jan 24, 2023
Merged

Update signature of Entity::markFieldUpdated#4398
nickvergessen merged 1 commit intomainfrom
techdebt/noid/update-signature-of-markFieldUpdated

Conversation

@nickvergessen
Copy link
Member

Ref nextcloud/server@e91457d

Summary

PHP Fatal error:  Declaration of OCA\Deck\Db\RelationalEntity::markFieldUpdated($attribute) must be compatible with OCP\AppFramework\Db\Entity::markFieldUpdated(string $attribute): void in /var/www/html/apps/deck/lib/Db/RelationalEntity.php on line 56
PHP Fatal error:  Declaration of OCA\Deck\Db\RelationalEntity::markFieldUpdated($attribute) must be compatible with OCP\AppFramework\Db\Entity::markFieldUpdated(string $attribute): void in /var/www/html/apps/deck/lib/Db/RelationalEntity.php on line 56
PHP Fatal error:  Declaration of OCA\Deck\Db\RelationalEntity::markFieldUpdated($attribute) must be compatible with OCP\AppFramework\Db\Entity::markFieldUpdated(string $attribute): void in /var/www/html/apps/deck/lib/Db/RelationalEntity.php on line 56

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

Signed-off-by: Joas Schilling <coding@schilljs.com>
Copy link
Member

@tobiasKaminsky tobiasKaminsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works with latest master

@nickvergessen
Copy link
Member Author

7.4 will be fixed in #4389

@nickvergessen nickvergessen merged commit 5ec251e into main Jan 24, 2023
@delete-merged-branch delete-merged-branch bot deleted the techdebt/noid/update-signature-of-markFieldUpdated branch January 24, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants