chore(settings): Move settings into assistant section#162
Merged
Conversation
Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
Member
Author
|
@kyteinsky Implemented feedback you mentioned in call. |
kyteinsky
reviewed
Aug 12, 2025
Contributor
kyteinsky
left a comment
kyteinsky
left a comment
There was a problem hiding this comment.
thanks, suggested a style fix.
Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
Contributor
|
there's an issue with two integration tests, force merging it for now since all other relevant tests pass. |
kyteinsky
pushed a commit
that referenced
this pull request
Aug 19, 2025
* chore(settings): Move settings into assistant section Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz> * Nested settings Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz> * change to h3 Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz> --------- Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves part of nextcloud/assistant#325 and also renames the Status header to Context Chat Status to be more clear.
