enh(addressbooks): add show/hide option for system and shared addressbooks

[JohannesGGE]

Fix: #479
Fix #2678

Changes:

• Show "Show" option for all address books, not just writeable one (Add new option to hide an address book's contacts without disabling the address book #479)
• Load disabled address book contacts to calc sum as shown in the screenshoot
• Refresh contacts on "Show"/Hide (Make Address Book disable operation responsive #2678)

For testing:

• Checkout enh(contacts): show/hide addressbooks for all server#38397
• Show/Hide of "Recently contacted" address book will be tackled in another issue

before	after

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: -1.83 ⚠️

Comparison is base (a3a6395) 1.82% compared to head (53b7a1f) 0.00%.

❗ Current head 53b7a1f differs from pull request most recent head a1e03d1. Consider uploading reports for the commit a1e03d1 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##              main   #3399      +/-   ##
==========================================
- Coverage     1.82%   0.00%   -1.83%     
  Complexity     272     272              
==========================================
  Files          112      25      -87     
  Lines         6091     826    -5265     
  Branches      1450       0    -1450     
==========================================
- Hits           111       0     -111     
+ Misses        5865     826    -5039     
+ Partials       115       0     -115     

Impacted Files	Coverage Δ
lib/Controller/PageController.php	0.00% <0.00%> (ø)

... and 87 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[GretaD]

works

[ChristophWurst]

just want to prevent a premature merge. is this PR usable without the change in server?

[JohannesGGE]

The show/hide change is just not possible and an error message is shown.

[GretaD]

No error is shown for me and it looks like it works fine, thats why i approved. I checked out both branches, server and contacts while testing.

Screencast.from.24.05.2023.16.31.27.webm

[JohannesGGE]

@GretaD Christoph meant the behaviour without the server PR checked out (because there is still a problem).

[ChristophWurst]

How about we fetch the address book ACLs and check for the write or property-write ACL. If it's there, show the button. Then this app can work with Nextcloud 28 but also 27, 26 and 25.

[JohannesGGE]

Yes, thats smart, I'll try to implement it.

[JohannesGGE]

The button is now shown depending on the ACLs.
cdav-library PR: nextcloud/cdav-library#789

[GretaD]

all looks good, but should i be able to share a hidden addressbook, maybe its out of scope for this one, but just fyi.

[JohannesGGE]

I think it's fine to have the option to share a hidden address book