Create service to handle what's new functionality

[ezaquarii]

No description provided.

[codecov]

Codecov Report

Merging #3898 into master will increase coverage by 0.06%.
The diff coverage is 13.54%.

@@             Coverage Diff             @@
##             master   #3898      +/-   ##
===========================================
+ Coverage      6.45%   6.52%   +0.06%     
  Complexity        1       1              
===========================================
  Files           325     328       +3     
  Lines         31247   31301      +54     
  Branches       4479    4481       +2     
===========================================
+ Hits           2018    2042      +24     
- Misses        28931   28963      +32     
+ Partials        298     296       -2

Impacted Files	Coverage Δ	Complexity Δ
...java/com/nextcloud/client/di/ComponentsModule.java	0% <ø> (ø)	0 <0> (ø)	⬇️
.../java/com/owncloud/android/utils/DisplayUtils.java	6.74% <ø> (+0.02%)	0 <0> (ø)	⬇️
...i/activities/data/files/RemoteFilesRepository.java	100% <ø> (ø)	0 <0> (ø)	⬇️
...m/nextcloud/client/account/UserAccountManager.java	0% <ø> (ø)	0 <0> (ø)	⬇️
...m/owncloud/android/ui/adapter/TemplateAdapter.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...ndroid/ui/dialog/ChooseTemplateDialogFragment.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...oud/android/ui/activity/NotificationsActivity.java	0% <0%> (ø)	0 <0> (ø)	⬇️
.../owncloud/android/files/services/FileUploader.java	0.2% <0%> (ø)	0 <0> (ø)	⬇️
...owncloud/android/ui/adapter/OCFileListAdapter.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...com/owncloud/android/ui/activity/BaseActivity.java	1.35% <0%> (-0.02%)	0 <0> (ø)
... and 56 more

[codecov]

Codecov Report

Merging #3898 into master will increase coverage by 0.04%.
The diff coverage is 22.91%.

@@             Coverage Diff             @@
##             master   #3898      +/-   ##
===========================================
+ Coverage      6.57%   6.62%   +0.04%     
  Complexity        1       1              
===========================================
  Files           322     326       +4     
  Lines         30922   30912      -10     
  Branches       4409    4408       -1     
===========================================
+ Hits           2034    2048      +14     
+ Misses        28592   28569      -23     
+ Partials        296     295       -1

Impacted Files	Coverage Δ	Complexity Δ
...java/com/nextcloud/client/di/ComponentsModule.java	0% <ø> (ø)	0 <0> (ø)	⬇️
.../android/authentication/AuthenticatorActivity.java	1.89% <ø> (ø)	0 <0> (ø)	⬇️
...ndroid/ui/asynctasks/LoadingVersionNumberTask.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...om/nextcloud/client/whatsnew/WhatsNewActivity.java	0% <0%> (ø)	0 <0> (?)
...owncloud/android/ui/activity/FirstRunActivity.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...ud/android/providers/DocumentsStorageProvider.java	1.06% <0%> (-0.01%)	0 <0> (ø)
src/main/java/com/owncloud/android/MainApp.java	47.51% <0%> (+1.31%)	0 <0> (ø)	⬇️
...perations/DetectAuthenticationMethodOperation.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...d/authentication/AccountAuthenticatorActivity.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...oud/android/ui/activity/SyncedFoldersActivity.java	0% <0%> (ø)	0 <0> (ø)	⬇️
... and 23 more

[ezaquarii]

com.owncloud.android.util.EncryptionTestIT is failing - I'm not sure if it's because I downgraded the lib to compile it.

[AndyScherzinger]

Latest master should work again 🤞

[ezaquarii]

> Task :spotbugsGplayDebug FAILED
1 actionable task: 1 executed
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':spotbugsGplayDebug'.
> A failure occurred while executing com.github.spotbugs.internal.spotbugs.SpotBugsRunner
> SpotBugs rule violations were found. See the report at: file:///drone/src/build/reports/spotbugs/spotbugs.html
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
* Get more help at https://help.gradle.org
BUILD FAILED in 1m 18s
found warnings: 429
previous warnings: 429
SUCCESS: count stayed the same
Branch: ezaquarii/create-whats-new-service
New lint results at https://www.kaminsky.me/nc-dev/android-lint/8891.html
New findbugs results at https://www.kaminsky.me/nc-dev/android-findbugs/8891.html
{
"message": "Not Found",
"documentation_url": "https://developer.github.com/v3"
}
lint.html file is missing! 

I'm not sure if there is actually anything wrong with it. @tobiasKaminsky can you pls take a look?

[tobiasKaminsky]

lint.html file is missing!

This means that lint did not run (completely), which is compiles all classes needed by spotBugs.
Having a look into the logs shows

The message received from the daemon indicates that the daemon has disappeared.

which means that somehow build process died.
In this we simply retry it.

[AndyScherzinger]

Looks good to me code-wise. I'm only reviewing it via phone atm, so waiting for @tobiasKaminsky's review and approval.

[ezaquarii]

@tobiasKaminsky @AndyScherzinger anything to do here? It's blocking my other work currently. ;)

[AndyScherzinger]

@ezaquarii fine with me 👍
I am just waiting for @tobiasKaminsky's review/approval/merge 😃

[AndyScherzinger]

@ezaquarii any reason for closing? Unfortunately still waiting for @tobiasKaminsky's review 😣

[ezaquarii]

WhatsNewActivity has been removed recently, so I think this refactoring is obsolete now.

[ezaquarii]

I keep the branch around to salvage remaining pieces of logic that could be still applicable elsewhere.

[AndyScherzinger]

I think the activity should still be there but won't be called since we haven't had any new features worth propagating this way in the near past but might have in the future again.
Tobias knows best.

[ezaquarii]

Youp, I looked at this code once again and you are right. I'll rebase.

[AndyScherzinger]

needs another rebase due to the changed spotbugs score which is due to the latest findbugs lib update: #3955

[AndyScherzinger]

pinging @tobiasKaminsky for review/merge :) Looks good from my pov. 👍

[nextcloud-android-bot]

Codacy

277

Lint

Type	master	PR
Warnings	59	59
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	25
Correctness Warnings	79
Internationalization Warnings	12
Malicious code vulnerability Warnings	4
Multithreaded correctness Warnings	9
Performance Warnings	174
Security Warnings	47
Dodgy code Warnings	141
Total	491

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	25
Correctness Warnings	81
Internationalization Warnings	15
Malicious code vulnerability Warnings	4
Multithreaded correctness Warnings	9
Performance Warnings	175
Security Warnings	47
Dodgy code Warnings	141
Total	497

[tobiasKaminsky]

I rebased it to latest master and tested it.
Works as expected.

Thanks again @ezaquarii for this great PR 🎉

[nextcloud-android-bot]

IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/9113

[nextcloud-android-bot]

Codacy

278

Lint

Type	master	PR
Warnings	58	58
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	25
Correctness Warnings	79
Internationalization Warnings	12
Malicious code vulnerability Warnings	4
Multithreaded correctness Warnings	9
Performance Warnings	174
Security Warnings	47
Dodgy code Warnings	141
Total	491

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	25
Correctness Warnings	81
Internationalization Warnings	15
Malicious code vulnerability Warnings	4
Multithreaded correctness Warnings	9
Performance Warnings	175
Security Warnings	47
Dodgy code Warnings	141
Total	497