Show note

[tobiasKaminsky]

This shows a note, if available, in file detail sharing fragment.
As it is only shown if a note is available, it is out of the box backward compatible.

Requires PR for server: nextcloud/server#12978

[AndyScherzinger]

@tobiasKaminsky corresponding lib change has been merged to master branch and jitpack build has been triggered and turned green, so jitpack lib master will ship the lib change now 👍

[AndyScherzinger]

pinging @schiessle for feedback/input ❤️

[tobiasKaminsky]

Is the note "ShareAble" good enough to recognize? (both on Android / web UI)

[AndyScherzinger]

Is the note "ShareAble" good enough to recognize? (both on Android / web UI)

I don't think so to be honest. It could maybe have the text file icon or something. Maybe @nextcloud/designers have a nice idea?

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (showSharedUser@191e12a). Click here to learn what that means.
The diff coverage is 18.18%.

@@               Coverage Diff                @@
##             showSharedUser   #3121   +/-   ##
================================================
  Coverage                  ?   6.18%           
  Complexity                ?       1           
================================================
  Files                     ?     317           
  Lines                     ?   30602           
  Branches                  ?    4397           
================================================
  Hits                      ?    1894           
  Misses                    ?   28422           
  Partials                  ?     286

Impacted Files	Coverage Δ	Complexity Δ
...ain/java/com/owncloud/android/db/ProviderMeta.java	88% <ø> (ø)	0 <0> (?)
...ncloud/android/ui/fragment/OCFileListFragment.java	0% <ø> (ø)	0 <0> (?)
...a/com/owncloud/android/utils/FileStorageUtils.java	12.3% <0%> (ø)	0 <0> (?)
...wncloud/android/providers/FileContentProvider.java	15.25% <0%> (ø)	0 <0> (?)
...android/ui/fragment/FileDetailSharingFragment.java	0% <0%> (ø)	0 <0> (?)
...in/java/com/owncloud/android/datamodel/OCFile.java	59.55% <100%> (ø)	0 <0> (?)
...loud/android/datamodel/FileDataStorageManager.java	10.74% <50%> (ø)	0 <0> (?)

[codecov]

Codecov Report

Merging #3121 into master will increase coverage by 0.05%.
The diff coverage is 4.34%.

@@             Coverage Diff             @@
##             master   #3121      +/-   ##
===========================================
+ Coverage      6.26%   6.31%   +0.05%     
  Complexity        1       1              
===========================================
  Files           318     318              
  Lines         31189   31214      +25     
  Branches       4467    4469       +2     
===========================================
+ Hits           1954    1972      +18     
- Misses        28942   28948       +6     
- Partials        293     294       +1

Impacted Files	Coverage Δ	Complexity Δ
...ain/java/com/owncloud/android/db/ProviderMeta.java	88% <ø> (ø)	0 <0> (ø)	⬇️
...loud/android/datamodel/ThumbnailsCacheManager.java	15.08% <ø> (ø)	0 <0> (ø)	⬇️
...ncloud/android/ui/fragment/FileDetailFragment.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...a/com/owncloud/android/utils/FileStorageUtils.java	8% <0%> (-0.05%)	0 <0> (ø)
...cloud/android/ui/adapter/FileDetailTabAdapter.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...owncloud/android/ui/adapter/OCFileListAdapter.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...wncloud/android/providers/FileContentProvider.java	18.9% <0%> (-0.23%)	0 <0> (ø)
...android/ui/fragment/FileDetailSharingFragment.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...in/java/com/owncloud/android/datamodel/OCFile.java	59.36% <100%> (+0.18%)	0 <0> (ø)	⬇️
...loud/android/datamodel/FileDataStorageManager.java	11.78% <50%> (+0.12%)	0 <0> (ø)	⬇️
... and 4 more

[jancborchardt]

Is the note "ShareAble" good enough to recognize? (both on Android / web UI)

I don't think so to be honest. It could maybe have the text file icon or something. Maybe @nextcloud/designers have a nice idea?

I’d say it’s good for the first pass – normally the note has some more explanatory content than just a word, and it’s inherently understandable as a note.

If we see it’s a problem in actual use, we can always add .icon-edit, the text document icon we also use for the "Add note" menu entry.

[AndyScherzinger]

@tobiasKaminsky needs a rebase and one question: is this ready to merge or does it need the server PR to be merged?

[tobiasKaminsky]

@tobiasKaminsky needs a rebase and one question: is this ready to merge or does it need the server PR to be merged?

This originally depended on #3320, but I rebased it onto master, which now results in duplicated classes/additions, so I would like to merge #3320 before this.
After merge of #3320 I'll do a rebase.

This still requires nextcloud/server#12978 to be merged.
Backward compability should be working out of the box as older server just do not respond to "nc:note".
But I'll test it then.

(sorry for the confusion)

[AndyScherzinger]

@tobiasKaminsky this is always false...

[tobiasKaminsky]

Good question, why I did this.
Maybe to test…
I'll fix it.

[tobiasKaminsky]

We ignore this for now. If there is a federated share, only the text generated avatar will be shown.
Ref: nextcloud/server#14564

[AndyScherzinger]

linebreak before the comment :)

[AndyScherzinger]

@tobiasKaminsky just two minor comments plus needs-rebase :)

[AndyScherzinger]

@tobiasKaminsky see review comments :)

[AndyScherzinger]

@tobiasKaminsky rebase 'n' merge? ❤️

[tobiasKaminsky]

Not quite…the part with federated icons is still open.
I hope I find time tomorrow :/

[tobiasKaminsky]

Finally done :-)

[nextcloud-android-bot]

Lint

Type	master	PR
Warnings	68	68
Errors	0	0

FindBugs (new)

Warning Type	Number
Bad practice Warnings	33
Correctness Warnings	118
Internationalization Warnings	15
Malicious code vulnerability Warnings	5
Multithreaded correctness Warnings	9
Performance Warnings	119
Security Warnings	56
Dodgy code Warnings	120
Total	475

FindBugs (master)

Warning Type	Number
Bad practice Warnings	33
Correctness Warnings	118
Internationalization Warnings	15
Malicious code vulnerability Warnings	5
Multithreaded correctness Warnings	9
Performance Warnings	119
Security Warnings	56
Dodgy code Warnings	120
Total	475