Conversation
ZetaTom
force-pushed
the
image-editor
branch
2 times, most recently
from
41bfb10 to
4809f35
Compare
|
stable-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/9200-IT-stable-11-35 |
|
master-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/9200-IT-master-11-52 |
|
blue-Light-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/11746-Screenshot-blue-Light-12-04 |
Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>
- reduce bottom margin of image editor control strip Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>
- added some comments Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>
- remove background colour from rounded_rect.xml Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>
Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>
Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11746.apk |
|
blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/11746-Screenshot-blue-Light-14-10 |
|
@ZetaTom I had one observation with this editor is that the size difference is more whenever we rotate the images. Is this much size reduction is expected or is there any way that it can be handled? |
|
@surinder-tsys Given the current implementation, this reduction in file size is to be expected as the image is re-compressed after each edit (after saving using ✅). This is handled by the Android-Image-Cropper Library. To avoid overwriting the original image with a version of inferior quality, we decided that edited images should be saved to a new file. It would be possible to implement rotation functionality without changing the actual image data by manipulating only the corresponding EXIF fields associated with the image. This would result in an (almost) identical file and file size, although it would be rotated by the image viewer itself. |
|
@ZetaTom Thanks for the explanation. |
|
@surinder-tsys To my knowledge, we don't have any plans to change this behaviour. |
5 participants
This change introduces an image editor, which enables users to crop, flip and rotate images on the fly. It supports a variety of different input formats, but is only able to produce JPEG, PNG and WEBP files as output due to the limitations of a system library.
closes #11608